You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/16 10:20:20 UTC

[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #416: feat(producer): auto create topic for producer

xujianhai666 opened a new pull request #416: feat(producer): auto create topic for producer
URL: https://github.com/apache/rocketmq-client-go/pull/416
 
 
   Closes #415

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] ShannonDing merged pull request #416: [ISSUE #415] feat(producer): auto create topic for producer

Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #416: [ISSUE #415] feat(producer): auto create topic for producer
URL: https://github.com/apache/rocketmq-client-go/pull/416
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] codecov-io commented on issue #416: feat(producer): auto create topic for producer

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #416: feat(producer): auto create topic for producer
URL: https://github.com/apache/rocketmq-client-go/pull/416#issuecomment-589967695
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/416?src=pr&el=h1) Report
   > Merging [#416](https://codecov.io/gh/apache/rocketmq-client-go/pull/416?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/adc707f730e136a1969d4f0ab7adffcb173ebd9f?src=pr&el=desc) will **decrease** coverage by `0.21%`.
   > The diff coverage is `6.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/416/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/416?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #416      +/-   ##
   ==========================================
   - Coverage    24.9%   24.69%   -0.22%     
   ==========================================
     Files          48       48              
     Lines        5480     5535      +55     
   ==========================================
   + Hits         1365     1367       +2     
   - Misses       3928     3980      +52     
   - Partials      187      188       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/416?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/namesrv.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/416/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbmFtZXNydi5nbw==) | `66% <ø> (ø)` | :arrow_up: |
   | [internal/mock\_namesrv.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/416/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9ja19uYW1lc3J2Lmdv) | `0% <0%> (ø)` | :arrow_up: |
   | [primitive/errors.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/416/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL2Vycm9ycy5nbw==) | `0% <0%> (ø)` | :arrow_up: |
   | [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/416/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.48% <0%> (-0.4%)` | :arrow_down: |
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/416/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.23% <0%> (ø)` | :arrow_up: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/416/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.3% <0%> (-0.55%)` | :arrow_down: |
   | [producer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/416/diff?src=pr&el=tree#diff-cHJvZHVjZXIvb3B0aW9uLmdv) | `38.29% <45.45%> (-2.73%)` | :arrow_down: |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/416/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `12.41% <0%> (+0.03%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/416?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/416?src=pr&el=footer). Last update [adc707f...5d9f6be](https://codecov.io/gh/apache/rocketmq-client-go/pull/416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] ShannonDing commented on issue #416: feat(producer): auto create topic for producer

Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #416: feat(producer): auto create topic for producer
URL: https://github.com/apache/rocketmq-client-go/pull/416#issuecomment-587513607
 
 
   CI error, go fmt for internal/route.go

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services