You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Richard Liang <ri...@gmail.com> on 2006/03/16 15:25:28 UTC
Re: [jira] Commented: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Mark Hindess (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/HARMONY-202?page=comments#action_12370684 ]
>
> Mark Hindess commented on HARMONY-202:
> --------------------------------------
>
> Looks good. All tests pass for me now. Thanks.
>
>
>
>
>> Non-ascii source file URITest breaking eclipse compiler test build
>> ------------------------------------------------------------------
>>
>> Key: HARMONY-202
>> URL: http://issues.apache.org/jira/browse/HARMONY-202
>> Project: Harmony
>> Type: Improvement
>> Components: Classlib
>> Reporter: Mark Hindess
>> Assignee: Tim Ellison
>> Priority: Trivial
>> Attachments: replace.non-ascii.with.escape.sequences.diff
>>
>> I will attach a patch to replace the non-ascii characters with \x escape sequences.
>>
>
>
Hello Tim & Mark,
Do we have any mandatory requirement about Harmony source file encoding?
or only US-ASCII is allowed. If yes, we shall document this requirement.
Any comments?
Thanks a lot.
--
Richard Liang
China Software Development Lab, IBM
Re: [jira] Commented: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Posted by Richard Liang <ri...@gmail.com>.
Tim Ellison wrote:
> Richard Liang wrote:
> <snip>
>
>> Do we have any mandatory requirement about Harmony source file encoding?
>> or only US-ASCII is allowed. If yes, we shall document this requirement.
>> Any comments?
>>
>
> In this case the Eclipse compiler running on the build machine failed to
> parse a particular source file encoding. We could fix it using the
> "-encoding <name>" argument, but it would be good for all our source
> files to be generally readable by simple text editors, etc.
>
> I would think the safest option is to use ASCII (and escape other
> characters).
>
>
I will agree with Tim. So we will set Window -> Preferences -> General
-> Workspace -> Text file encoding as US-ASCII.
> Regards,
> Tim
>
>
--
Richard Liang
China Software Development Lab, IBM
Re: [jira] Commented: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Posted by Tim Ellison <t....@gmail.com>.
Richard Liang wrote:
<snip>
> Do we have any mandatory requirement about Harmony source file encoding?
> or only US-ASCII is allowed. If yes, we shall document this requirement.
> Any comments?
In this case the Eclipse compiler running on the build machine failed to
parse a particular source file encoding. We could fix it using the
"-encoding <name>" argument, but it would be good for all our source
files to be generally readable by simple text editors, etc.
I would think the safest option is to use ASCII (and escape other
characters).
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.