You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/01 09:05:37 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2334: [Enhancement] Method calls Condition.signal() rather than Condition.signalAll()
Alonexc opened a new issue, #2334:
URL: https://github.com/apache/incubator-eventmesh/issues/2334
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-connector-plugin/eventmesh-connector-standalone/src/main/java/org/apache/eventmesh/connector/standalone/broker/MessageQueue.java line 191 212 220
analysis and explanation:
Condition.signalAll() is preferred over Condition.signal(). Calling signal() only wakes up one thread, meaning that the thread woken up might not be the one waiting for the condition that the caller just satisfied.
### Describe the solution you'd like
Change to use Condition.signalAll().
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx closed issue #2334: [Enhancement] Method calls Condition.signal() rather than Condition.signalAll()
Posted by GitBox <gi...@apache.org>.
jonyangx closed issue #2334: [Enhancement] Method calls Condition.signal() rather than Condition.signalAll()
URL: https://github.com/apache/incubator-eventmesh/issues/2334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org