You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/29 00:18:08 UTC
[GitHub] [flink] blublinsky opened a new pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
blublinsky opened a new pull request #14512:
URL: https://github.com/apache/flink/pull/14512
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Flink implementation is often a part of the larger application. As a result a synchronized management - clean up of Flink resources, when a main application is deleted is important. In Kubernetes, a common approach for such clean up is usage of the owner's reference (https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)
This PR allows adding owner reference support to Flink Job manager
## Brief change log
- Add configuration for owner reference
- Add Owner manager resource
- Add Owner manager support to KubernetesJobManagerParameters
- Updated Job Manager factory to process owner's reference
- Updated Job Manager factory unit test
## Verifying this change
This change added tests and can be verified as follows:
Extended InitJobManagerDecoratorTest to validate owner reference support
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) yes
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know) yes
- The S3 file system connector: (yes / no / don't know)no
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) java doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-756157781
THanks @wangyang0918,
This is exactly what I have done.
And here https://github.com/blublinsky/flink/tree/ownerreference is my branch,
But when I am trying to create a pr - https://github.com/apache/flink/compare/master...blublinsky:ownerreference?expand=1,
it tries to create a new PR, this is what I did last time. I do not see a way to force it to the existing PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on a change in pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on a change in pull request #14512:
URL: https://github.com/apache/flink/pull/14512#discussion_r549761543
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesOwnerReference.java
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.resources;
+
+import io.fabric8.kubernetes.api.model.OwnerReference;
+import io.fabric8.kubernetes.api.model.OwnerReferenceBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+
+/**
+ * Represent Toleration resource in kubernetes.
+ */
+public class KubernetesOwnerReference extends KubernetesResource<OwnerReference> {
+
+ static final String API_VERSION = "apiversion";
Review comment:
I had them private initially, but decided to make them public, so that they can be used for programmatic implementation.
When I am writing code that creates owner reference, its handy to have them available.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
}, {
"hash" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465",
"triggerID" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86f6502cf9980ff8d7fd15fe058588eb9f5004cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415)
* f965d2f71ffd0123a2832183022d0951e83952d9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86f6502cf9980ff8d7fd15fe058588eb9f5004cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-756529695
I think maybe you have delete the old forked repository of this PR. Currently it is on an unknown repository. I am not sure whether you could fix it[1]. If not, let's move the discussion to another PR.
[1]. https://stackoverflow.com/questions/36071272/fix-unknown-repository-of-an-opened-pr-after-deleted-the-fork
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
}, {
"hash" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465",
"triggerID" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"triggerType" : "PUSH"
}, {
"hash" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11468",
"triggerID" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"triggerType" : "PUSH"
}, {
"hash" : "655b2992fd97e20ef142287bfd435832c469261d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11481",
"triggerID" : "655b2992fd97e20ef142287bfd435832c469261d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 655b2992fd97e20ef142287bfd435832c469261d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11481)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86f6502cf9980ff8d7fd15fe058588eb9f5004cf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-756042313
@blublinsky Do you mean you have delete the fork repository manually? I just want to share how I develop the PRs.
* Fork the flink project
* Add the forked remote repository to local, `git remote add myfork https://github.com/xxxx/flink.git`. Then you could have at least following two remote repositories.
```
myfork https://github.com/xxxx/flink.git (fetch)
myfork https://github.com/xxxx/flink.git (push)
upstream https://github.com/apache/flink.git (fetch)
upstream https://github.com/apache/flink.git (push)
```
* Checkout a new branch(e.g. `ownerreference`) from master(`upstream` repository)
* Develop the PR and push to myfork. `git push myfork ownerreference`
* Create the PR in the github
* Address the comments, update the PR and force push. `git push -f myfork ownerreference`
* The PR should be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on a change in pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on a change in pull request #14512:
URL: https://github.com/apache/flink/pull/14512#discussion_r549761543
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesOwnerReference.java
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.resources;
+
+import io.fabric8.kubernetes.api.model.OwnerReference;
+import io.fabric8.kubernetes.api.model.OwnerReferenceBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+
+/**
+ * Represent Toleration resource in kubernetes.
+ */
+public class KubernetesOwnerReference extends KubernetesResource<OwnerReference> {
+
+ static final String API_VERSION = "apiversion";
Review comment:
I had them private initially, but decided to make them public, so that they can be used for programmatic definitions.
When I am writing code that creates owner reference, its handy to have them available
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-755541392
Sorry guys, how do I force the same PR. Unfortunately not a GIT guru
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on a change in pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on a change in pull request #14512:
URL: https://github.com/apache/flink/pull/14512#discussion_r549773457
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/InitJobManagerDecorator.java
##########
@@ -63,6 +64,9 @@ public FlinkPod decorateFlinkPod(FlinkPod flinkPod) {
.editOrNewMetadata()
.withLabels(kubernetesJobManagerParameters.getLabels())
.withAnnotations(kubernetesJobManagerParameters.getAnnotations())
+ .withOwnerReferences(kubernetesJobManagerParameters.getOwnerReference().stream()
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on a change in pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on a change in pull request #14512:
URL: https://github.com/apache/flink/pull/14512#discussion_r549764345
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/InitJobManagerDecorator.java
##########
@@ -63,6 +64,9 @@ public FlinkPod decorateFlinkPod(FlinkPod flinkPod) {
.editOrNewMetadata()
.withLabels(kubernetesJobManagerParameters.getLabels())
.withAnnotations(kubernetesJobManagerParameters.getAnnotations())
+ .withOwnerReferences(kubernetesJobManagerParameters.getOwnerReference().stream()
Review comment:
oh yes, my bad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on a change in pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on a change in pull request #14512:
URL: https://github.com/apache/flink/pull/14512#discussion_r549764142
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesOwnerReference.java
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.resources;
+
+import io.fabric8.kubernetes.api.model.OwnerReference;
+import io.fabric8.kubernetes.api.model.OwnerReferenceBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+
+/**
+ * Represent Toleration resource in kubernetes.
+ */
+public class KubernetesOwnerReference extends KubernetesResource<OwnerReference> {
+
+ static final String API_VERSION = "apiversion";
+ static final String DELETION = "blockownerdeletion";
+ static final String CONTROLLER = "controller";
+ static final String KIND = "kind";
+ static final String NAME = "name";
+ static final String UUID = "uid";
+
+ private static final Logger LOG = LoggerFactory.getLogger(KubernetesOwnerReference.class);
+
+ private KubernetesOwnerReference(OwnerReference ownerReference) {
+ super(ownerReference);
+ }
+
+ public static KubernetesOwnerReference fromMap(Map<String, String> stringMap) {
+ final OwnerReferenceBuilder ownerReferenceBuilder = new OwnerReferenceBuilder();
+ stringMap.forEach((k, v) -> {
+ switch (k.toLowerCase()) {
Review comment:
Here is the formal definition https://github.com/kubernetes/apimachinery/blob/21de1bffe600f61f4873ae774a60f7a7d37ac9bf/pkg/apis/meta/v1/types.go#L273-L275. According to it controller and BlockOwnerDeletion are optional. But for practical use, it is my understanding, that everything is required
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
}, {
"hash" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465",
"triggerID" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"triggerType" : "PUSH"
}, {
"hash" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f965d2f71ffd0123a2832183022d0951e83952d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465)
* ef398a6aca683bb22074d7a72abd6a328981610e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-760610375
Sorry for that I missed the new PR for the replacement https://github.com/apache/flink/pull/14591.
Let's move the review and discussion there. And then this PR could be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751903408
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 86f6502cf9980ff8d7fd15fe058588eb9f5004cf (Tue Dec 29 00:19:59 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
}, {
"hash" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465",
"triggerID" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"triggerType" : "PUSH"
}, {
"hash" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11468",
"triggerID" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"triggerType" : "PUSH"
}, {
"hash" : "655b2992fd97e20ef142287bfd435832c469261d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11481",
"triggerID" : "655b2992fd97e20ef142287bfd435832c469261d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef398a6aca683bb22074d7a72abd6a328981610e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11468)
* 655b2992fd97e20ef142287bfd435832c469261d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11481)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86f6502cf9980ff8d7fd15fe058588eb9f5004cf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751903408
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 655b2992fd97e20ef142287bfd435832c469261d (Fri May 28 07:08:20 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
}, {
"hash" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86f6502cf9980ff8d7fd15fe058588eb9f5004cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415)
* f965d2f71ffd0123a2832183022d0951e83952d9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a change in pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14512:
URL: https://github.com/apache/flink/pull/14512#discussion_r550018222
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesOwnerReference.java
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.resources;
+
+import io.fabric8.kubernetes.api.model.OwnerReference;
+import io.fabric8.kubernetes.api.model.OwnerReferenceBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+
+/**
+ * Represent Toleration resource in kubernetes.
+ */
+public class KubernetesOwnerReference extends KubernetesResource<OwnerReference> {
+
+ static final String API_VERSION = "apiversion";
Review comment:
IIUC, you mean to refer these variables in your own java program, not Flink source codes. Since `KubernetesOwnerReference` is an internal class, which should not be directly used out of Flink. So I am afraid it does not make sense to set these variables `public`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-755303213
cc @blublinsky Actually you do not have to open a new PR every time after addressing the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-755844471
@blublinsky First, address the comments and update the source codes locally. Then refine the commit message via `git commit --amend` or `git rebase -i master`. Last, force push the local branch(e.g. `ownerreference`) to remote via `git push blublinsky ownerreference`. Please remember that `blublinsky:ownerreference` is the branch which you create the PR with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a change in pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14512:
URL: https://github.com/apache/flink/pull/14512#discussion_r549678052
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/decorators/InitJobManagerDecoratorTest.java
##########
@@ -67,6 +68,12 @@
new Toleration("NoSchedule", "key1", "Equal", null, "value1"),
new Toleration("NoExecute", "key2", "Exists", 6000L, null));
+ private static final String OWNER_REFERENCE_STRING = "apiVersion:cloudflow.io/v1beta1,blockOwnerDeletion:true,"
+ + "controller:true,kind:FlinkApplication,name:testapp,uid:e3c9aa3f-cc42-4178-814a-64aa15c82373";
+ private static final List<OwnerReference> OWNER_REFERENCES = Arrays.asList(
Review comment:
```suggestion
private static final List<OwnerReference> OWNER_REFERENCES = Collections.singletonList(
```
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesOwnerReference.java
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.resources;
+
+import io.fabric8.kubernetes.api.model.OwnerReference;
+import io.fabric8.kubernetes.api.model.OwnerReferenceBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+
+/**
+ * Represent Toleration resource in kubernetes.
+ */
+public class KubernetesOwnerReference extends KubernetesResource<OwnerReference> {
+
+ static final String API_VERSION = "apiversion";
+ static final String DELETION = "blockownerdeletion";
+ static final String CONTROLLER = "controller";
+ static final String KIND = "kind";
+ static final String NAME = "name";
+ static final String UUID = "uid";
+
+ private static final Logger LOG = LoggerFactory.getLogger(KubernetesOwnerReference.class);
+
+ private KubernetesOwnerReference(OwnerReference ownerReference) {
+ super(ownerReference);
+ }
+
+ public static KubernetesOwnerReference fromMap(Map<String, String> stringMap) {
+ final OwnerReferenceBuilder ownerReferenceBuilder = new OwnerReferenceBuilder();
+ stringMap.forEach((k, v) -> {
+ switch (k.toLowerCase()) {
Review comment:
I have a question here. Do we have to set all the fields to build an `OwnerReference`?
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/InitJobManagerDecorator.java
##########
@@ -63,6 +64,9 @@ public FlinkPod decorateFlinkPod(FlinkPod flinkPod) {
.editOrNewMetadata()
.withLabels(kubernetesJobManagerParameters.getLabels())
.withAnnotations(kubernetesJobManagerParameters.getAnnotations())
+ .withOwnerReferences(kubernetesJobManagerParameters.getOwnerReference().stream()
Review comment:
I am afraid that we could not set owner reference to the JobManager pod. I believe you mean to set the owner reference to the JobManager deployment.
Then this piece of codes should be moved into `KubernetesJobManagerFactory#createJobManagerDeployment`.
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesOwnerReference.java
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.resources;
+
+import io.fabric8.kubernetes.api.model.OwnerReference;
+import io.fabric8.kubernetes.api.model.OwnerReferenceBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+
+/**
+ * Represent Toleration resource in kubernetes.
+ */
+public class KubernetesOwnerReference extends KubernetesResource<OwnerReference> {
+
+ static final String API_VERSION = "apiversion";
Review comment:
These variables could be `private`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-752796891
Rebased this PR, it is now https://github.com/apache/flink/pull/14529/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
}, {
"hash" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465",
"triggerID" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"triggerType" : "PUSH"
}, {
"hash" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11468",
"triggerID" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef398a6aca683bb22074d7a72abd6a328981610e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11468)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-752058313
This PR also needs to rebase the latest master branch to resolve conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #14512:
URL: https://github.com/apache/flink/pull/14512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-755848208
Oh, my problem is that I am working from the local fork, that I updated to get the latest version. So my previous fork is gone, thats why it created a new commit. So now from a new fork I can't push to the same PR, because it recognizes that my fork has changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
}, {
"hash" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465",
"triggerID" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"triggerType" : "PUSH"
}, {
"hash" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11468",
"triggerID" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f965d2f71ffd0123a2832183022d0951e83952d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465)
* ef398a6aca683bb22074d7a72abd6a328981610e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11468)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-752367340
@blublinsky It seems that you have introduced too many unrelated changes in this PR. Could you rebase the latest master branch? I believe the conflicts is caused by huge refactor commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-751906693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11415",
"triggerID" : "86f6502cf9980ff8d7fd15fe058588eb9f5004cf",
"triggerType" : "PUSH"
}, {
"hash" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11465",
"triggerID" : "f965d2f71ffd0123a2832183022d0951e83952d9",
"triggerType" : "PUSH"
}, {
"hash" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11468",
"triggerID" : "ef398a6aca683bb22074d7a72abd6a328981610e",
"triggerType" : "PUSH"
}, {
"hash" : "655b2992fd97e20ef142287bfd435832c469261d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "655b2992fd97e20ef142287bfd435832c469261d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef398a6aca683bb22074d7a72abd6a328981610e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11468)
* 655b2992fd97e20ef142287bfd435832c469261d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14512: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14512:
URL: https://github.com/apache/flink/pull/14512#issuecomment-755516473
The benefit of sticking to the same PR (by (force) pushing changes is that we keep track of the history of changes).
I'm closing the other PR. Please push your changes here!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org