[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25097: [SPARK-28015][SQL] Check stringToDate() consumes entire input for the yyyy and yyyy-[m]m formats

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #25097: [SPARK-28015][SQL] Check stringToDate() consumes entire input for the yyyy and yyyy-[m]m formats
URL: https://github.com/apache/spark/pull/25097#discussion_r302168622
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/results/pgSQL/date.sql.out
 ##########
 @@ -198,17 +198,29 @@ struct<DATE '1999-01-18':date>
 -- !query 21
 SELECT date '1999 Jan 08'
 -- !query 21 schema
-struct<DATE '1999-01-01':date>
+struct<>
 -- !query 21 output
-1999-01-01
 
 Review comment:
   Oops. I missed this. Thank you for the catching this. 
   cc @wangyum , too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org