[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #345: Fix build errors

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #345:
URL: https://github.com/apache/incubator-nuttx-apps/pull/345#discussion_r461401263



##########
File path: Application.mk
##########
@@ -88,6 +88,7 @@ ifneq ($(BUILD_MODULE),y)
 endif
 
 ROOTDEPPATH += --dep-path .

Review comment:
       DEPPATH is used consitently in nuttx folder. Why not convert all ROOTDEPPATH to DEPPATH?

##########
File path: Application.mk
##########
@@ -88,6 +88,7 @@ ifneq ($(BUILD_MODULE),y)
 endif
 
 ROOTDEPPATH += --dep-path .

Review comment:
       Yes, it's better to unify into DEPPATH, thanks.

##########
File path: system/spi/Kconfig
##########
@@ -15,7 +15,7 @@ if SYSTEM_SPITOOL
 
 config SPITOOL_PROGNAME
 	string "Program name"
-	default "hello"
+	default "spi"

Review comment:
       need remove CONFIG_SPITOOL_PROGNAME from these defconfig:
   boards/arm/s32k1xx/rddrone-uavcan144/configs/nsh/defconfig
   boards/arm/s32k1xx/rddrone-uavcan144/configs/nshdebug/defconfig
   boards/arm/s32k1xx/rddrone-uavcan146/configs/nsh/defconfig
   boards/arm/s32k1xx/rddrone-uavcan146/configs/nshdebug/defconfig
   otherwise the build will break:
   https://github.com/apache/incubator-nuttx-apps/pull/345/checks?check_run_id=917971406

##########
File path: system/spi/Kconfig
##########
@@ -15,7 +15,7 @@ if SYSTEM_SPITOOL
 
 config SPITOOL_PROGNAME
 	string "Program name"
-	default "hello"
+	default "spi"

Review comment:
       Only commiter can restart the check, I will do it once apache/incubator-nuttx#1477 get merged.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org