You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "guixiaowen (via GitHub)" <gi...@apache.org> on 2026/01/20 15:02:08 UTC
[PR] [ARUON #1541] Add work flow for iceberg #1541 #1536 [auron]
guixiaowen opened a new pull request, #1936:
URL: https://github.com/apache/auron/pull/1936
<!--
- Start the PR title with the related issue ID, e.g. '[AURON #XXXX] Short summary...'.
-->
# Which issue does this PR close?
Closes #<issue_number>
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
# How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARUON #1541] Add work flow for iceberg #1541 #1536 [auron]
Posted by "ShreyeshArangath (via GitHub)" <gi...@apache.org>.
ShreyeshArangath commented on code in PR #1936:
URL: https://github.com/apache/auron/pull/1936#discussion_r2709849620
##########
.github/workflows/iceberg.yml:
##########
@@ -0,0 +1,68 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Iceberg
+
+on:
+ workflow_dispatch:
+ push:
+ branches:
+ - master
+ - branch-*
+ pull_request:
+ branches:
+ - master
+ - branch-*
+
+concurrency:
+ group: iceberg-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test-flink:
Review Comment:
```suggestion
test-iceberg:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARUON #1541] Add work flow for iceberg #1541 #1536 [auron]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1936:
URL: https://github.com/apache/auron/pull/1936#discussion_r2710956402
##########
.github/workflows/iceberg.yml:
##########
@@ -0,0 +1,68 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Iceberg
+
+on:
+ workflow_dispatch:
+ push:
+ branches:
+ - master
+ - branch-*
+ pull_request:
+ branches:
+ - master
+ - branch-*
+
+concurrency:
+ group: iceberg-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test-flink:
+ name: Test Iceberg ${{ matrix.iceberg }} javaVersion ${{ matrix.javaver }} scalaVersion ${{ matrix.scalaver }}
+ runs-on: ubuntu-24.04
+ strategy:
+ fail-fast: false
+ matrix:
+ iceberg: [ "1.10.1" ]
+ javaver: [ "17"]
+ scalaver: [ "2.12", "2.13"" ]
+ module: [ "thirdparty/auron-iceberg" ]
+ sparkver: [ "spark-3.4", "spark-3.5" ]
+
+
+ steps:
+ - name: Checkout Auron
+ uses: actions/checkout@v4
+
+ - name: Setup Java and Maven cache
+ uses: actions/setup-java@v4
Review Comment:
The workflow is using an outdated version of the setup-java action. Other similar workflows in the repository (flink.yml, paimon.yml) use actions/setup-java@v5, while this workflow uses actions/setup-java@v4. For consistency and to use the latest features and security updates, this should be updated to v5.
```suggestion
uses: actions/setup-java@v5
```
##########
.github/workflows/iceberg.yml:
##########
@@ -0,0 +1,68 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Iceberg
+
+on:
+ workflow_dispatch:
+ push:
+ branches:
+ - master
+ - branch-*
+ pull_request:
+ branches:
+ - master
+ - branch-*
+
+concurrency:
+ group: iceberg-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test-flink:
+ name: Test Iceberg ${{ matrix.iceberg }} javaVersion ${{ matrix.javaver }} scalaVersion ${{ matrix.scalaver }}
+ runs-on: ubuntu-24.04
+ strategy:
+ fail-fast: false
+ matrix:
+ iceberg: [ "1.10.1" ]
+ javaver: [ "17"]
+ scalaver: [ "2.12", "2.13"" ]
Review Comment:
There's a syntax error in the YAML array definition. The line has two double quotes after "2.13" which will cause the workflow to fail parsing. The correct syntax should have only one double quote at the end of the array.
```suggestion
scalaver: [ "2.12", "2.13" ]
```
##########
.github/workflows/iceberg.yml:
##########
@@ -0,0 +1,68 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Iceberg
+
+on:
+ workflow_dispatch:
+ push:
+ branches:
+ - master
+ - branch-*
+ pull_request:
+ branches:
+ - master
+ - branch-*
+
+concurrency:
+ group: iceberg-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test-flink:
+ name: Test Iceberg ${{ matrix.iceberg }} javaVersion ${{ matrix.javaver }} scalaVersion ${{ matrix.scalaver }}
+ runs-on: ubuntu-24.04
+ strategy:
+ fail-fast: false
+ matrix:
+ iceberg: [ "1.10.1" ]
+ javaver: [ "17"]
+ scalaver: [ "2.12", "2.13"" ]
+ module: [ "thirdparty/auron-iceberg" ]
+ sparkver: [ "spark-3.4", "spark-3.5" ]
+
+
+ steps:
+ - name: Checkout Auron
+ uses: actions/checkout@v4
+
+ - name: Setup Java and Maven cache
+ uses: actions/setup-java@v4
+ with:
+ distribution: 'adopt-hotspot'
+ java-version: ${{ matrix.javaver }}
+ cache: 'maven'
+
+ - name: Test Iceberg Module
+ run: ./build/mvn -B test -X -pl ${{ matrix.module }} -am -Pscala-${{ matrix.scalaver }} -Piceberg-${{ matrix.iceberg }} -P${{ matrix.sparkver }} -Prelease
Review Comment:
The Maven test command includes the -X flag which enables debug output. This flag is not used in other similar workflows (flink.yml, paimon.yml) in the repository and will produce verbose output that can clutter the CI logs. Unless debug output is specifically needed for troubleshooting, this flag should be removed for consistency with other workflows.
```suggestion
run: ./build/mvn -B test -pl ${{ matrix.module }} -am -Pscala-${{ matrix.scalaver }} -Piceberg-${{ matrix.iceberg }} -P${{ matrix.sparkver }} -Prelease
```
##########
.github/workflows/iceberg.yml:
##########
@@ -0,0 +1,68 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Iceberg
+
+on:
+ workflow_dispatch:
+ push:
+ branches:
+ - master
+ - branch-*
+ pull_request:
+ branches:
+ - master
+ - branch-*
+
+concurrency:
+ group: iceberg-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test-flink:
+ name: Test Iceberg ${{ matrix.iceberg }} javaVersion ${{ matrix.javaver }} scalaVersion ${{ matrix.scalaver }}
+ runs-on: ubuntu-24.04
+ strategy:
+ fail-fast: false
+ matrix:
+ iceberg: [ "1.10.1" ]
+ javaver: [ "17"]
+ scalaver: [ "2.12", "2.13"" ]
+ module: [ "thirdparty/auron-iceberg" ]
+ sparkver: [ "spark-3.4", "spark-3.5" ]
+
+
+ steps:
+ - name: Checkout Auron
+ uses: actions/checkout@v4
+
+ - name: Setup Java and Maven cache
+ uses: actions/setup-java@v4
+ with:
+ distribution: 'adopt-hotspot'
+ java-version: ${{ matrix.javaver }}
+ cache: 'maven'
+
+ - name: Test Iceberg Module
+ run: ./build/mvn -B test -X -pl ${{ matrix.module }} -am -Pscala-${{ matrix.scalaver }} -Piceberg-${{ matrix.iceberg }} -P${{ matrix.sparkver }} -Prelease
+
+ - name: Upload reports
+ if: failure()
+ uses: actions/upload-artifact@v4
Review Comment:
The workflow is using an outdated version of the upload-artifact action. Other similar workflows in the repository (flink.yml, paimon.yml) use actions/upload-artifact@v6, while this workflow uses actions/upload-artifact@v4. For consistency and to use the latest features and security updates, this should be updated to v6.
```suggestion
uses: actions/upload-artifact@v6
```
##########
.github/workflows/iceberg.yml:
##########
@@ -0,0 +1,68 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Iceberg
+
+on:
+ workflow_dispatch:
+ push:
+ branches:
+ - master
+ - branch-*
+ pull_request:
+ branches:
+ - master
+ - branch-*
+
+concurrency:
+ group: iceberg-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test-flink:
+ name: Test Iceberg ${{ matrix.iceberg }} javaVersion ${{ matrix.javaver }} scalaVersion ${{ matrix.scalaver }}
+ runs-on: ubuntu-24.04
+ strategy:
+ fail-fast: false
+ matrix:
+ iceberg: [ "1.10.1" ]
+ javaver: [ "17"]
+ scalaver: [ "2.12", "2.13"" ]
+ module: [ "thirdparty/auron-iceberg" ]
+ sparkver: [ "spark-3.4", "spark-3.5" ]
+
+
+ steps:
+ - name: Checkout Auron
+ uses: actions/checkout@v4
Review Comment:
The workflow is using an outdated version of the checkout action. Other similar workflows in the repository (flink.yml, paimon.yml) use actions/checkout@v6, while this workflow uses actions/checkout@v4. For consistency and to use the latest features and security updates, this should be updated to v6.
```suggestion
uses: actions/checkout@v6
```
##########
.github/workflows/iceberg.yml:
##########
@@ -0,0 +1,68 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Iceberg
+
+on:
+ workflow_dispatch:
+ push:
+ branches:
+ - master
+ - branch-*
+ pull_request:
+ branches:
+ - master
+ - branch-*
+
+concurrency:
+ group: iceberg-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test-flink:
Review Comment:
The job name is "test-flink" but this workflow is testing Iceberg modules, not Flink. The job name should be updated to accurately reflect what is being tested, such as "test-iceberg" or "test-iceberg-module".
```suggestion
test-iceberg:
```
##########
.github/workflows/iceberg.yml:
##########
@@ -0,0 +1,68 @@
+#
Review Comment:
The PR title contains a spelling error. "ARUON" should be spelled "AURON" to match the project name used throughout the workflow file (see line 50 "Checkout Auron").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARUON #1541] Add work flow for iceberg #1541 #1536 [auron]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen closed pull request #1936: [ARUON #1541] Add work flow for iceberg #1541 #1536
URL: https://github.com/apache/auron/pull/1936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org