You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2022/06/10 14:08:06 UTC

[GitHub] [struts] lukaszlenart opened a new pull request, #566: [WW-5185] Reintroduces proper implementation of Tiles resource to support wildcard matching of Tiles definitions

lukaszlenart opened a new pull request, #566:
URL: https://github.com/apache/struts/pull/566

   Refs [WW-5185](https://issues.apache.org/jira/browse/WW-5185)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] coveralls commented on pull request #566: [WW-5185] Reintroduces proper implementation of Tiles resource to support wildcard matching of Tiles definitions

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #566:
URL: https://github.com/apache/struts/pull/566#issuecomment-1152436976

   
   [![Coverage Status](https://coveralls.io/builds/49924936/badge)](https://coveralls.io/builds/49924936)
   
   Coverage decreased (-0.01%) to 50.619% when pulling **9a2996f9b794f546461a43d4e927ba387f197209 on WW-5185-struts-resource** into **4b3ee53f939ac040b6d5351591eace6023d78514 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] yasserzamani commented on pull request #566: [WW-5185] Reintroduces proper implementation of Tiles resource to support wildcard matching of Tiles definitions

Posted by GitBox <gi...@apache.org>.
yasserzamani commented on PR #566:
URL: https://github.com/apache/struts/pull/566#issuecomment-1152945214

   Thanks LGTM :+1: just one thing: Does this mean that Tiles itself `URLApplicationResource` is not implemented properly to support wildcard matching? Or is it a bug in Tiles `URLApplicationResource` impl? ... if so then shouldn't it be fixed there instead of here at Struts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] yasserzamani merged pull request #566: [WW-5185] Reintroduces proper implementation of Tiles resource to support wildcard matching of Tiles definitions

Posted by GitBox <gi...@apache.org>.
yasserzamani merged PR #566:
URL: https://github.com/apache/struts/pull/566


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] lukaszlenart commented on pull request #566: [WW-5185] Reintroduces proper implementation of Tiles resource to support wildcard matching of Tiles definitions

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on PR #566:
URL: https://github.com/apache/struts/pull/566#issuecomment-1153085162

   `URLApplicationResource` was intended to work with multiple localized Tiles definitions, eg.: `tiles.xml, tiles_pl.xml, tiles_fr.xml` and so one, `StrutsApplicationResource` is connected with `StrutsWildcardServletApplicationContext` to support wildcard matching, but without localisation support - it's done via [`I18N:`](https://struts.apache.org/plugins/tiles/#i18n) prefix. Probably I should clarify that in the docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org