You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by hebelala <gi...@git.apache.org> on 2017/08/11 10:45:06 UTC

[GitHub] curator pull request #234: Fix, maybe cannot deleteChildren completely when ...

GitHub user hebelala opened a pull request:

    https://github.com/apache/curator/pull/234

    Fix, maybe cannot deleteChildren completely when multi-client delete concurrently

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hebelala/curator master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #234
    
----
commit ca1e9fbbb28a9deaa7f6187f321fd446f471db6d
Author: hebelala <he...@qq.com>
Date:   2017-08-11T10:39:21Z

     Fix, maybe cannot deleteChildren completely when multi-client delete concurrently

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request #234: Fix, maybe cannot deleteChildren completely when ...

Posted by hebelala <gi...@git.apache.org>.
Github user hebelala closed the pull request at:

    https://github.com/apache/curator/pull/234


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator issue #234: Fix, maybe cannot deleteChildren completely when multi-c...

Posted by hebelala <gi...@git.apache.org>.
Github user hebelala commented on the issue:

    https://github.com/apache/curator/pull/234
  
    see https://github.com/apache/curator/pull/235, please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator issue #234: Fix, maybe cannot deleteChildren completely when multi-c...

Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:

    https://github.com/apache/curator/pull/234
  
    Please review https://cwiki.apache.org/confluence/display/CURATOR/Submitting+Pull+Requests
    
    - There must be a JIRA Issue created for your change
    - Create a git branch with the same name as the Issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator issue #234: Fix, maybe cannot deleteChildren completely when multi-c...

Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:

    https://github.com/apache/curator/pull/234
  
    Also, I don't know what the need for this is. ZKPaths is an internal utility and the Curator code that uses it already ignores the exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator issue #234: Fix, maybe cannot deleteChildren completely when multi-c...

Posted by hebelala <gi...@git.apache.org>.
Github user hebelala commented on the issue:

    https://github.com/apache/curator/pull/234
  
    use `curatorFramework.delete().deletingChildrenIfNeeded().forPath(path)`, this sync api doesn't ignore the NoNodeException, causes the rest of children nodes will not be deleted perhaps.
    
    `zookeeper.getChildren(path, null)` maybe throw NoNodeException, if the path doesn't exist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---