You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by gr...@apache.org on 2009/08/27 22:46:45 UTC

svn commit: r808619 - in /incubator/log4php/trunk/src: changes/changes.xml main/php/LoggerReflectionUtils.php

Author: grobmeier
Date: Thu Aug 27 20:46:45 2009
New Revision: 808619

URL: http://svn.apache.org/viewvc?rev=808619&view=rev
Log:
LOG4PHP-77: Applied patch from Dan Hansen: LoggerReflectionUtils::setter() should be defined as a static method

Modified:
    incubator/log4php/trunk/src/changes/changes.xml
    incubator/log4php/trunk/src/main/php/LoggerReflectionUtils.php

Modified: incubator/log4php/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/changes/changes.xml?rev=808619&r1=808618&r2=808619&view=diff
==============================================================================
--- incubator/log4php/trunk/src/changes/changes.xml (original)
+++ incubator/log4php/trunk/src/changes/changes.xml Thu Aug 27 20:46:45 2009
@@ -72,6 +72,7 @@
 		<action type="fix" issue="LOG4PHP-67">Refactoring: Use Logger instead of LoggerManager (Christian Hammers)</action>
 		<action type="fix" issue="LOG4PHP-71">Using LoggerAppenderFile logging to the log file in one Apache session blocks every other Apache session that tries to write to the file until the original request has been processed (Christian Grobmeier)</action>
 		<action type="fix" issue="LOG4PHP-76" by="Dan Hansen">Unable to configure socket appender with attribute useXml = true</action>
+		<action type="fix" issue="LOG4PHP-77" by="Dan Hansen">LoggerReflectionUtils::setter() should be defined as a static method</action>
 		<action type="update">Initial port to PHP 5 (Knut Urdalen)</action>
 		<action type="update">Established new unit test suite (Knut Urdalen)</action>
 		<action type="update">Added a range of examples (Knut Urdalen)</action>

Modified: incubator/log4php/trunk/src/main/php/LoggerReflectionUtils.php
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/LoggerReflectionUtils.php?rev=808619&r1=808618&r2=808619&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/LoggerReflectionUtils.php (original)
+++ incubator/log4php/trunk/src/main/php/LoggerReflectionUtils.php Thu Aug 27 20:46:45 2009
@@ -139,7 +139,7 @@
      * @param string $name
      * @param mixed $value
      */
-    public function setter($object, $name, $value) {
+    public static function setter($object, $name, $value) {
         if (empty($name)) {
             return false;
         }