Clover now running again on ZooKeeper trunk

[Patrick Hunt <ph...@apache.org>]

Clover has been re-installed on the hadoop# jenkins machines. I've
updated our job to again run clover against nightly ZK trunk.
https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/

Notice that our coverage has been declining over the past few weeks.
Not good. Committers please be sure that changes are accompanied by
adequate testing.

Patrick

Re: Clover now running again on ZooKeeper trunk

[Patrick Hunt <ph...@apache.org>]

Thanks Camille for looking into this! I also noticed that the kerberos
patch introduced a number of new compiler warnings, it would be great
if we could knock compiler warnings down to 0:
https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/1292/warningsResult/

Patrick

On Fri, Sep 2, 2011 at 3:57 PM, Camille Fournier <ca...@apache.org> wrote:
> Being the coverage obsessive that I am, I drilled into this and it
> looks like it's basically entirely the Kerberos patch that caused the
> coverage change. If we care I suspect there's a few edges there that
> could take unit testing. Everything else seemed to stay the same or go
> up.
>
> C
>
> On Fri, Sep 2, 2011 at 2:47 PM, Patrick Hunt <ph...@apache.org> wrote:
>> Clover has been re-installed on the hadoop# jenkins machines. I've
>> updated our job to again run clover against nightly ZK trunk.
>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/
>>
>> Notice that our coverage has been declining over the past few weeks.
>> Not good. Committers please be sure that changes are accompanied by
>> adequate testing.
>>
>> Patrick
>>
>

Re: Clover now running again on ZooKeeper trunk

[Camille Fournier <ca...@apache.org>]

Being the coverage obsessive that I am, I drilled into this and it
looks like it's basically entirely the Kerberos patch that caused the
coverage change. If we care I suspect there's a few edges there that
could take unit testing. Everything else seemed to stay the same or go
up.

C

On Fri, Sep 2, 2011 at 2:47 PM, Patrick Hunt <ph...@apache.org> wrote:
> Clover has been re-installed on the hadoop# jenkins machines. I've
> updated our job to again run clover against nightly ZK trunk.
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/
>
> Notice that our coverage has been declining over the past few weeks.
> Not good. Committers please be sure that changes are accompanied by
> adequate testing.
>
> Patrick
>