You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/30 10:17:46 UTC
[GitHub] [spark] yaooqinn opened a new pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
yaooqinn opened a new pull request #29303:
URL: https://github.com/apache/spark/pull/29303
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
This PR fulfills some missing fields for SparkGetColumnsOperation
### Why are the changes needed?
make jdbc tools happier
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes,
#### before
#### after
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666648383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667925208
**[Test build #126974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126974/testReport)** for PR 29303 at commit [`cf34aa3`](https://github.com/apache/spark/commit/cf34aa3fced16d61b75e362a418d8c67a7de7023).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667861064
**[Test build #126960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126960/testReport)** for PR 29303 at commit [`66d5812`](https://github.com/apache/spark/commit/66d581258d729e397fdf5525276f82cd6e66c2ec).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667868517
**[Test build #126965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126965/testReport)** for PR 29303 at commit [`8e1a276`](https://github.com/apache/spark/commit/8e1a2769c5453b353eee0c59d6a133f2cf6df961).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463480658
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,47 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType => None
+ case ArrayType(et, _) => getColumnSize(et)
+ case MapType(kt, vt, _) =>
+ val kSize = getColumnSize(kt)
+ val vSize = getColumnSize(vt)
+ if (kSize.isEmpty || vSize.isEmpty) {
+ None
+ } else {
+ Some(kSize.get + vSize.get)
+ }
+ case StructType(fields) =>
+ val sizeArr = fields.map(f => getColumnSize(f.dataType))
+ if (sizeArr.contains(None)) {
+ None
+ } else {
+ Some(sizeArr.map(_.get).sum)
+ }
+ case other => Some(other.defaultSize)
+ }
+
+ private def getDecimalDigits(typ: DataType): Option[Int] = typ match {
+ case BooleanType | _: IntegerType => Some(0)
+ case FloatType => Some(7)
+ case DoubleType => Some(15)
Review comment:
how do we pick these numbers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464293696
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,52 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ /**
+ * For numeric and datetime types, it returns the default size of its catalyst type
+ * For struct type, when its elements are fixed-size, the summation of all element sizes will be
+ * returned.
+ * For array, map, string, and binaries, the column size is variable, return null as unknown.
+ */
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType | _: ArrayType | _: MapType => None
+ case StructType(fields) =>
+ val sizeArr = fields.map(f => getColumnSize(f.dataType))
+ if (sizeArr.contains(None)) {
+ None
+ } else {
+ Some(sizeArr.map(_.get).sum)
+ }
+ case other => Some(other.defaultSize)
Review comment:
nit: I think it's safer to list the types we know the size, instead of listing the types we don't know the size. I'd prefer
```
case dt @ (_: NumericType || DateType || TimestampType) => dt.defaultSize
...
```
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,52 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ /**
+ * For numeric and datetime types, it returns the default size of its catalyst type
+ * For struct type, when its elements are fixed-size, the summation of all element sizes will be
+ * returned.
+ * For array, map, string, and binaries, the column size is variable, return null as unknown.
+ */
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType | _: ArrayType | _: MapType => None
+ case StructType(fields) =>
+ val sizeArr = fields.map(f => getColumnSize(f.dataType))
+ if (sizeArr.contains(None)) {
+ None
+ } else {
+ Some(sizeArr.map(_.get).sum)
+ }
+ case other => Some(other.defaultSize)
Review comment:
nit: I think it's safer to list the types we know the size, instead of listing the types we don't know the size. I'd prefer
```
case dt @ (_: NumericType | DateType | TimestampType) => dt.defaultSize
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667071115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464379318
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -141,17 +179,17 @@ private[hive] class SparkGetColumnsOperation(
column.name, // COLUMN_NAME
toJavaSQLType(column.dataType.sql).asInstanceOf[AnyRef], // DATA_TYPE
column.dataType.sql, // TYPE_NAME
- null, // COLUMN_SIZE
+ getColumnSize(column.dataType).map(_.asInstanceOf[AnyRef]).orNull, // COLUMN_SIZE
null, // BUFFER_LENGTH, unused
- null, // DECIMAL_DIGITS
- null, // NUM_PREC_RADIX
+ getDecimalDigits(column.dataType).map(_.asInstanceOf[AnyRef]).orNull, // DECIMAL_DIGITS
+ getNumPrecRadix(column.dataType).map(_.asInstanceOf[AnyRef]).orNull, // NUM_PREC_RADIX
(if (column.nullable) 1 else 0).asInstanceOf[AnyRef], // NULLABLE
column.getComment().getOrElse(""), // REMARKS
null, // COLUMN_DEF
null, // SQL_DATA_TYPE
null, // SQL_DATETIME_SUB
null, // CHAR_OCTET_LENGTH
- null, // ORDINAL_POSITION
+ pos.asInstanceOf[AnyRef], // ORDINAL_POSITION
"YES", // IS_NULLABLE
Review comment:
Should this respect `column.nullable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464165400
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,52 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ /**
+ * For numeric and datetime types, it returns the default size of its catalyst type
+ * For struct type, when its elements are fixed-size, the summation of all element sizes will be
+ * returned.
+ * For array, map, string, and binaries, the column size is variable, return null as unknown.
+ */
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
Review comment:
Hive does not return same result for each type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463601005
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,52 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ /**
+ * For numeric and datetime types, it returns the default size of its catalyst type
+ * For struct type, when its elements are fixed-size, the summation of all element sizes will be
+ * returned.
+ * For array, map, string, and binaries, the column size is variable, return null as unknown.
+ */
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
Review comment:
Hive returns the almost same values for column size?
https://github.com/apache/hive/blob/3e5e99eae154ceb8f9aa4e4ec71e6b05310e98e4/service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java#L187-L211
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,79 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("SparkGetColumnsOperation") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val decimalType = DecimalType(10, 2)
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName
Review comment:
I think we don't a strict rule for the format though, how about following the existing format?
https://github.com/apache/spark/blob/8014b0b5d61237dc4851d4ae9927778302d692da/sql/core/src/test/scala/org/apache/spark/sql/ShowCreateTableSuite.scala#L35-L41
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,79 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("SparkGetColumnsOperation") {
Review comment:
Please make this test title clearer, too.
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,79 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("SparkGetColumnsOperation") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val decimalType = DecimalType(10, 2)
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName
+ | (
+ | a boolean comment '0',
Review comment:
Could you test all the types where possible for test coverage?
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,79 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("SparkGetColumnsOperation") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val decimalType = DecimalType(10, 2)
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName
+ | (
+ | a boolean comment '0',
+ | b int comment '1',
+ | c float comment '2',
+ | d ${decimalType.sql} comment '3',
+ | e array<long> comment '4',
+ | f array<string> comment '5',
+ | g map<smallint, tinyint> comment '6',
+ | h date comment '7',
+ | i timestamp comment '8',
+ | j struct<X: bigint,Y: double> comment '9'
+ | ) using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
+ val rowSet = client.fetchResults(getCol)
+ val columns = rowSet.toTRowSet.getColumns
+ assert(columns.get(0).getStringVal.getValues.asScala.forall(_.isEmpty),
+ "catalog name mismatches")
+
+ assert(columns.get(1).getStringVal.getValues.asScala.forall(_ == schemaName),
+ "schema name mismatches")
+
+ assert(columns.get(2).getStringVal.getValues.asScala.forall(_ == tableName),
+ "table name mismatches")
+
+ // column name
+ columns.get(3).getStringVal.getValues.asScala.zipWithIndex.foreach {
+ case (v, i) => assert(v === ('a' + i).toChar.toString, "column name mismatches")
+ }
+
+ val javaTypes = columns.get(4).getI32Val.getValues
+ assert(javaTypes.get(3).intValue() === java.sql.Types.DECIMAL)
+ assert(javaTypes.get(6).intValue() === java.sql.Types.JAVA_OBJECT)
+
+ val typeNames = columns.get(5).getStringVal.getValues
+ assert(typeNames.get(3) === decimalType.sql)
+
+ val colSize = columns.get(6).getI32Val.getValues
+ assert(colSize.get(3).intValue() === decimalType.defaultSize)
Review comment:
Could you check all the elements in `colSize`? (Rather, I think we need to check all elements in the fetched `rowSet`.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666949073
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126845/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666885517
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667886205
**[Test build #126965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126965/testReport)** for PR 29303 at commit [`8e1a276`](https://github.com/apache/spark/commit/8e1a2769c5453b353eee0c59d6a133f2cf6df961).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464803705
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
BTW, this is not a flaky failure. This broke some profiles consistently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667846526
**[Test build #126960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126960/testReport)** for PR 29303 at commit [`66d5812`](https://github.com/apache/spark/commit/66d581258d729e397fdf5525276f82cd6e66c2ec).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666948803
**[Test build #126845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126845/testReport)** for PR 29303 at commit [`2a319ff`](https://github.com/apache/spark/commit/2a319ff00d0dde63209f6df7427abe26ece2f85d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class ExecutorProcessLost(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464747511
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
Let's revert if it takes a while to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666949060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463508347
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,47 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType => None
+ case ArrayType(et, _) => getColumnSize(et)
+ case MapType(kt, vt, _) =>
+ val kSize = getColumnSize(kt)
+ val vSize = getColumnSize(vt)
+ if (kSize.isEmpty || vSize.isEmpty) {
+ None
+ } else {
+ Some(kSize.get + vSize.get)
+ }
+ case StructType(fields) =>
+ val sizeArr = fields.map(f => getColumnSize(f.dataType))
+ if (sizeArr.contains(None)) {
+ None
+ } else {
+ Some(sizeArr.map(_.get).sum)
+ }
+ case other => Some(other.defaultSize)
+ }
+
+ private def getDecimalDigits(typ: DataType): Option[Int] = typ match {
+ case BooleanType | _: IntegerType => Some(0)
+ case FloatType => Some(7)
+ case DoubleType => Some(15)
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667941575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464729279
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
The part I'm not sure is that the difference between PRBuilder and the other Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464803567
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
Ya. It seems that Hive 2.3 is affected. And, JDK11 maven seems not running those test suite.
Do we have a follow-up idea, @yaooqinn and @cloud-fan ?
The error message is clear, `java.lang.ClassCastException`. If there is no idea, I'd like to recommend to revert first and pass Maven Jenkins properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667847385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666876471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666969367
**[Test build #126867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126867/testReport)** for PR 29303 at commit [`2a319ff`](https://github.com/apache/spark/commit/2a319ff00d0dde63209f6df7427abe26ece2f85d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-668004308
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666657478
**[Test build #126807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126807/testReport)** for PR 29303 at commit [`cc8c90d`](https://github.com/apache/spark/commit/cc8c90dc8167dca649eae4642a43e97aa8e8f3c1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666657478
**[Test build #126807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126807/testReport)** for PR 29303 at commit [`cc8c90d`](https://github.com/apache/spark/commit/cc8c90dc8167dca649eae4642a43e97aa8e8f3c1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666949060
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666969367
**[Test build #126867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126867/testReport)** for PR 29303 at commit [`2a319ff`](https://github.com/apache/spark/commit/2a319ff00d0dde63209f6df7427abe26ece2f85d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666930652
**[Test build #126845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126845/testReport)** for PR 29303 at commit [`2a319ff`](https://github.com/apache/spark/commit/2a319ff00d0dde63209f6df7427abe26ece2f85d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667886647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464729021
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
Hi, @yaooqinn and @cloud-fan . I'm not sure but this new test case seems to break all Jenkins `Maven` job on `master` branch. Could you take a look?
```
org.apache.hive.service.cli.HiveSQLException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.ClassCastException: org.apache.hadoop.hive.ql.security.HadoopDefaultAuthenticator cannot be cast to org.apache.hadoop.hive.ql.security.HiveAuthenticationProvider
at org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.checkStatus(ThriftCLIServiceClient.java:42)
at org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.getColumns(ThriftCLIServiceClient.java:275)
at org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextSuite.$anonfun$$init$$17(ThriftServerWithSparkContextSuite.scala:146)
```
From the screenshot, please ignore SBT failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667846526
**[Test build #126960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126960/testReport)** for PR 29303 at commit [`66d5812`](https://github.com/apache/spark/commit/66d581258d729e397fdf5525276f82cd6e66c2ec).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666871141
@yaooqinn FYI to make the GitHub Actions tests pass, you might have to rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463487059
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,47 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType => None
+ case ArrayType(et, _) => getColumnSize(et)
+ case MapType(kt, vt, _) =>
+ val kSize = getColumnSize(kt)
+ val vSize = getColumnSize(vt)
+ if (kSize.isEmpty || vSize.isEmpty) {
+ None
+ } else {
+ Some(kSize.get + vSize.get)
+ }
+ case StructType(fields) =>
+ val sizeArr = fields.map(f => getColumnSize(f.dataType))
+ if (sizeArr.contains(None)) {
+ None
+ } else {
+ Some(sizeArr.map(_.get).sum)
+ }
+ case other => Some(other.defaultSize)
+ }
+
+ private def getDecimalDigits(typ: DataType): Option[Int] = typ match {
+ case BooleanType | _: IntegerType => Some(0)
+ case FloatType => Some(7)
+ case DoubleType => Some(15)
Review comment:
They are from hive's `TypeDescriptor` and I also checked the results, which are same from hive and spark, e.g. `select 0.12345678901234567890D`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666942749
**[Test build #126852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126852/testReport)** for PR 29303 at commit [`2a319ff`](https://github.com/apache/spark/commit/2a319ff00d0dde63209f6df7427abe26ece2f85d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666969899
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464779658
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
Not all maven builds are broken:
Let's wait a little bit and see if it's an env issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666708684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666967995
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667861278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667918830
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667941249
**[Test build #126974 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126974/testReport)** for PR 29303 at commit [`cf34aa3`](https://github.com/apache/spark/commit/cf34aa3fced16d61b75e362a418d8c67a7de7023).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667861278
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667918830
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463507410
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,47 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType => None
+ case ArrayType(et, _) => getColumnSize(et)
Review comment:
oh, right...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463502884
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,47 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType => None
+ case ArrayType(et, _) => getColumnSize(et)
+ case MapType(kt, vt, _) =>
+ val kSize = getColumnSize(kt)
+ val vSize = getColumnSize(vt)
+ if (kSize.isEmpty || vSize.isEmpty) {
+ None
+ } else {
+ Some(kSize.get + vSize.get)
+ }
+ case StructType(fields) =>
+ val sizeArr = fields.map(f => getColumnSize(f.dataType))
+ if (sizeArr.contains(None)) {
+ None
+ } else {
+ Some(sizeArr.map(_.get).sum)
+ }
+ case other => Some(other.defaultSize)
+ }
+
+ private def getDecimalDigits(typ: DataType): Option[Int] = typ match {
+ case BooleanType | _: IntegerType => Some(0)
+ case FloatType => Some(7)
+ case DoubleType => Some(15)
Review comment:
Can we add a code comment to explain it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666986891
**[Test build #126867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126867/testReport)** for PR 29303 at commit [`2a319ff`](https://github.com/apache/spark/commit/2a319ff00d0dde63209f6df7427abe26ece2f85d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class ExecutorProcessLost(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464729021
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
Hi, @yaooqinn and @cloud-fan . I'm not sure but this new test case seems to break all Jenkins `Maven` jobs on `master` branch. Could you take a look?
```
org.apache.hive.service.cli.HiveSQLException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.ClassCastException: org.apache.hadoop.hive.ql.security.HadoopDefaultAuthenticator cannot be cast to org.apache.hadoop.hive.ql.security.HiveAuthenticationProvider
at org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.checkStatus(ThriftCLIServiceClient.java:42)
at org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.getColumns(ThriftCLIServiceClient.java:275)
at org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextSuite.$anonfun$$init$$17(ThriftServerWithSparkContextSuite.scala:146)
```
From the screenshot, please ignore SBT failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29303:
URL: https://github.com/apache/spark/pull/29303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667071115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666930652
**[Test build #126845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126845/testReport)** for PR 29303 at commit [`2a319ff`](https://github.com/apache/spark/commit/2a319ff00d0dde63209f6df7427abe26ece2f85d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464751471
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
Looks like something related to another version of Hive which belong to another job(maybe failed) not being cleaned up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464157516
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,79 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("SparkGetColumnsOperation") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val decimalType = DecimalType(10, 2)
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName
Review comment:
OK, this one looks better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666987195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463483396
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -141,17 +174,17 @@ private[hive] class SparkGetColumnsOperation(
column.name, // COLUMN_NAME
toJavaSQLType(column.dataType.sql).asInstanceOf[AnyRef], // DATA_TYPE
column.dataType.sql, // TYPE_NAME
- null, // COLUMN_SIZE
+ getColumnSize(column.dataType).map(_.asInstanceOf[AnyRef]).orNull, // COLUMN_SIZE
Review comment:
Could you make the title and description clearer? e.g., which field does this PR add (COLUMN_SIZE, DECIMAL_DIGITS, and NUM_PREC_RADIX, and ORDINAL_POSITION?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666942749
**[Test build #126852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126852/testReport)** for PR 29303 at commit [`2a319ff`](https://github.com/apache/spark/commit/2a319ff00d0dde63209f6df7427abe26ece2f85d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667848766
> To check if we could fetch the new metadata via `DatabaseMetaData`, could you add tests in `SparkMetadataOperationSuite`, too?
The new test can end to end cover the meta operations both for binary and HTTP mode, but SparkMetadataOperationSuite seems only works for binary only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666885517
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666871499
I see, thanks, @HyukjinKwon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666876471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667868517
**[Test build #126965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126965/testReport)** for PR 29303 at commit [`8e1a276`](https://github.com/apache/spark/commit/8e1a2769c5453b353eee0c59d6a133f2cf6df961).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666706975
**[Test build #126807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126807/testReport)** for PR 29303 at commit [`cc8c90d`](https://github.com/apache/spark/commit/cc8c90dc8167dca649eae4642a43e97aa8e8f3c1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667869556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667092676
**[Test build #126887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126887/testReport)** for PR 29303 at commit [`5ec2092`](https://github.com/apache/spark/commit/5ec2092bcf3b07bc693da2a6226b968d8eee2fcc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464803900
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
BTW, it's up to you, @cloud-fan . I'll not revert this since PRBuilder is still working.
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
BTW, it's up to you, @cloud-fan . I'll not revert this by myself since PRBuilder is still working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463487940
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,47 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType => None
+ case ArrayType(et, _) => getColumnSize(et)
+ case MapType(kt, vt, _) =>
+ val kSize = getColumnSize(kt)
+ val vSize = getColumnSize(vt)
+ if (kSize.isEmpty || vSize.isEmpty) {
+ None
+ } else {
+ Some(kSize.get + vSize.get)
+ }
+ case StructType(fields) =>
+ val sizeArr = fields.map(f => getColumnSize(f.dataType))
+ if (sizeArr.contains(None)) {
+ None
+ } else {
+ Some(sizeArr.map(_.get).sum)
+ }
+ case other => Some(other.defaultSize)
+ }
+
+ private def getDecimalDigits(typ: DataType): Option[Int] = typ match {
+ case BooleanType | _: IntegerType => Some(0)
+ case FloatType => Some(7)
+ case DoubleType => Some(15)
Review comment:
the result is `0.12345678901234568` which have 17 decimal digits but hive says its 15 for double...
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,47 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType => None
+ case ArrayType(et, _) => getColumnSize(et)
+ case MapType(kt, vt, _) =>
+ val kSize = getColumnSize(kt)
+ val vSize = getColumnSize(vt)
+ if (kSize.isEmpty || vSize.isEmpty) {
+ None
+ } else {
+ Some(kSize.get + vSize.get)
+ }
+ case StructType(fields) =>
+ val sizeArr = fields.map(f => getColumnSize(f.dataType))
+ if (sizeArr.contains(None)) {
+ None
+ } else {
+ Some(sizeArr.map(_.get).sum)
+ }
+ case other => Some(other.defaultSize)
+ }
+
+ private def getDecimalDigits(typ: DataType): Option[Int] = typ match {
+ case BooleanType | _: IntegerType => Some(0)
+ case FloatType => Some(7)
+ case DoubleType => Some(15)
Review comment:
the result is `0.12345678901234568` which have 17 decimal digits but hive says it's 15 for double...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666969889
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666967995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667925208
**[Test build #126974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126974/testReport)** for PR 29303 at commit [`cf34aa3`](https://github.com/apache/spark/commit/cf34aa3fced16d61b75e362a418d8c67a7de7023).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463503195
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,47 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType => None
+ case ArrayType(et, _) => getColumnSize(et)
Review comment:
how can we report column size for array type? We don't know how many elements in an array.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666968355
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463491365
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -141,17 +174,17 @@ private[hive] class SparkGetColumnsOperation(
column.name, // COLUMN_NAME
toJavaSQLType(column.dataType.sql).asInstanceOf[AnyRef], // DATA_TYPE
column.dataType.sql, // TYPE_NAME
- null, // COLUMN_SIZE
+ getColumnSize(column.dataType).map(_.asInstanceOf[AnyRef]).orNull, // COLUMN_SIZE
Review comment:
OK, thanks Takeshi ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666864487
cc @cloud-fan @gatorsmile @maropu @wangyum thanks very much
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666708684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463490761
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -126,12 +124,47 @@ private[hive] class SparkGetColumnsOperation(
HiveThriftServer2.eventManager.onStatementFinish(statementId)
}
+ private def getColumnSize(typ: DataType): Option[Int] = typ match {
+ case StringType | BinaryType => None
+ case ArrayType(et, _) => getColumnSize(et)
+ case MapType(kt, vt, _) =>
+ val kSize = getColumnSize(kt)
+ val vSize = getColumnSize(vt)
+ if (kSize.isEmpty || vSize.isEmpty) {
+ None
+ } else {
+ Some(kSize.get + vSize.get)
+ }
+ case StructType(fields) =>
+ val sizeArr = fields.map(f => getColumnSize(f.dataType))
+ if (sizeArr.contains(None)) {
+ None
+ } else {
+ Some(sizeArr.map(_.get).sum)
+ }
+ case other => Some(other.defaultSize)
+ }
+
+ private def getDecimalDigits(typ: DataType): Option[Int] = typ match {
+ case BooleanType | _: IntegerType => Some(0)
+ case FloatType => Some(7)
+ case DoubleType => Some(15)
Review comment:
It seems to follow `IEEE 754` https://en.wikipedia.org/wiki/IEEE_754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666884004
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666648383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667111632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667102957
To check if we could fetch the new metadata via `DatabaseMetaData`, could you add tests in `SparkMetadataOperationSuite`, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464729021
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,135 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("check results from get columns operation from thrift server") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val schema = new StructType()
+ .add("c0", "boolean", nullable = false, "0")
+ .add("c1", "tinyint", nullable = true, "1")
+ .add("c2", "smallint", nullable = false, "2")
+ .add("c3", "int", nullable = true, "3")
+ .add("c4", "long", nullable = false, "4")
+ .add("c5", "float", nullable = true, "5")
+ .add("c6", "double", nullable = false, "6")
+ .add("c7", "decimal(38, 20)", nullable = true, "7")
+ .add("c8", "decimal(10, 2)", nullable = false, "8")
+ .add("c9", "string", nullable = true, "9")
+ .add("c10", "array<long>", nullable = false, "10")
+ .add("c11", "array<string>", nullable = true, "11")
+ .add("c12", "map<smallint, tinyint>", nullable = false, "12")
+ .add("c13", "date", nullable = true, "13")
+ .add("c14", "timestamp", nullable = false, "14")
+ .add("c15", "struct<X: bigint,Y: double>", nullable = true, "15")
+ .add("c16", "binary", nullable = false, "16")
+
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName (
+ | ${schema.toDDL}
+ |)
+ |using parquet""".stripMargin
+
+ withCLIServiceClient { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String, java.lang.String]
+ val opHandle = client.executeStatement(sessionHandle, ddl, confOverlay)
+ var status = client.getOperationStatus(opHandle)
+ while (!status.getState.isTerminal) {
+ Thread.sleep(10)
+ status = client.getOperationStatus(opHandle)
+ }
+ val getCol = client.getColumns(sessionHandle, "", schemaName, tableName, null)
Review comment:
Hi, @yaooqinn and @cloud-fan . I'm not sure but this new test case seems to break all Jenkins job on `master` branch. Could you take a look?
```
org.apache.hive.service.cli.HiveSQLException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.ClassCastException: org.apache.hadoop.hive.ql.security.HadoopDefaultAuthenticator cannot be cast to org.apache.hadoop.hive.ql.security.HiveAuthenticationProvider
at org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.checkStatus(ThriftCLIServiceClient.java:42)
at org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.getColumns(ThriftCLIServiceClient.java:275)
at org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextSuite.$anonfun$$init$$17(ThriftServerWithSparkContextSuite.scala:146)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667941575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667847385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667869556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463592697
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,79 @@ trait ThriftServerWithSparkContextSuite extends SharedThriftServer {
}
}
}
+
+ test("SparkGetColumnsOperation") {
+ val schemaName = "default"
+ val tableName = "spark_get_col_operation"
+ val decimalType = DecimalType(10, 2)
+ val ddl =
+ s"""
+ |CREATE TABLE $schemaName.$tableName
Review comment:
I think we don't have a strict rule for the format though, how about following the existing format?
https://github.com/apache/spark/blob/8014b0b5d61237dc4851d4ae9927778302d692da/sql/core/src/test/scala/org/apache/spark/sql/ShowCreateTableSuite.scala#L35-L41
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666967788
**[Test build #126852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126852/testReport)** for PR 29303 at commit [`2a319ff`](https://github.com/apache/spark/commit/2a319ff00d0dde63209f6df7427abe26ece2f85d).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class ExecutorProcessLost(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667861289
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126960/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667092676
**[Test build #126887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126887/testReport)** for PR 29303 at commit [`5ec2092`](https://github.com/apache/spark/commit/5ec2092bcf3b07bc693da2a6226b968d8eee2fcc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667886647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666968001
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126852/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667111632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-667111282
**[Test build #126887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126887/testReport)** for PR 29303 at commit [`5ec2092`](https://github.com/apache/spark/commit/5ec2092bcf3b07bc693da2a6226b968d8eee2fcc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r464382897
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -141,17 +179,17 @@ private[hive] class SparkGetColumnsOperation(
column.name, // COLUMN_NAME
toJavaSQLType(column.dataType.sql).asInstanceOf[AnyRef], // DATA_TYPE
column.dataType.sql, // TYPE_NAME
- null, // COLUMN_SIZE
+ getColumnSize(column.dataType).map(_.asInstanceOf[AnyRef]).orNull, // COLUMN_SIZE
null, // BUFFER_LENGTH, unused
- null, // DECIMAL_DIGITS
- null, // NUM_PREC_RADIX
+ getDecimalDigits(column.dataType).map(_.asInstanceOf[AnyRef]).orNull, // DECIMAL_DIGITS
+ getNumPrecRadix(column.dataType).map(_.asInstanceOf[AnyRef]).orNull, // NUM_PREC_RADIX
(if (column.nullable) 1 else 0).asInstanceOf[AnyRef], // NULLABLE
column.getComment().getOrElse(""), // REMARKS
null, // COLUMN_DEF
null, // SQL_DATA_TYPE
null, // SQL_DATETIME_SUB
null, // CHAR_OCTET_LENGTH
- null, // ORDINAL_POSITION
+ pos.asInstanceOf[AnyRef], // ORDINAL_POSITION
"YES", // IS_NULLABLE
Review comment:
IS_NULLABLE is related to PK, "YES" here is more specific as we don't have such thing implemented
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information for thriftserver client tools
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29303:
URL: https://github.com/apache/spark/pull/29303#issuecomment-666987195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org