You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/12/20 13:14:12 UTC
[PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]
XComp opened a new pull request, #23962:
URL: https://github.com/apache/flink/pull/23962
Based on the following PR(s):
* https://github.com/apache/flink/pull/23961
## What is the purpose of the change
See FLINK-27082 and FLINK-33903 for context
## Brief change log
* Disables/Ignores tests that rely on setting the file permissions to see that if the permissions are not granted will trigger error handling
## Verifying this change
Tests are disabled. No issue is expected.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #23962:
URL: https://github.com/apache/flink/pull/23962#discussion_r1433172250
##########
flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java:
##########
@@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws IOException {
}
@Test
+ @Ignore("FLINK-27082: Fails in Docker with root user")
Review Comment:
Wouldn't it be better to create interface something like `FailsOnDockerWithRoot`
and with help of `@Category` mark tests failing for the specific maven profile?
Like it is done for
https://github.com/apache/flink/blob/cabb28d25c4c58af3ee23fc4a63f9564aefd6146/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/FailsOnJava17.java#L21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #23962:
URL: https://github.com/apache/flink/pull/23962#discussion_r1434112468
##########
flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java:
##########
@@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws IOException {
}
@Test
+ @Ignore("FLINK-27082: Fails in Docker with root user")
Review Comment:
That's actually a good idea. I haven't thought of it. But that way, we could disable the tests in GHA but keep them in Azure CI. I'm gonna look into it :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #23962:
URL: https://github.com/apache/flink/pull/23962#discussion_r1434558666
##########
flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java:
##########
@@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws IOException {
}
@Test
+ @Ignore("FLINK-27082: Fails in Docker with root user")
Review Comment:
I updated the PR according to your idea. :+1:
The following two GHA workflow runs include this PR:
* [build #68](https://github.com/XComp/flink/actions/runs/7292799860) does not have the profile activated
* [build #70](https://github.com/XComp/flink/actions/runs/7292859288) does have the profile activated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #23962:
URL: https://github.com/apache/flink/pull/23962#discussion_r1433172250
##########
flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java:
##########
@@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws IOException {
}
@Test
+ @Ignore("FLINK-27082: Fails in Docker with root user")
Review Comment:
Wouldn't it be better to create interface something like `FailsOnDockerWithRoot`
and with help of `@Category` mark tests failing for the specific maven profile
like it is done for
https://github.com/apache/flink/blob/cabb28d25c4c58af3ee23fc4a63f9564aefd6146/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/FailsOnJava17.java#L21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #23962:
URL: https://github.com/apache/flink/pull/23962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23962:
URL: https://github.com/apache/flink/pull/23962#issuecomment-1864463518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c06b5080ace2436c9840da6f69725ac78371ace2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c06b5080ace2436c9840da6f69725ac78371ace2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c06b5080ace2436c9840da6f69725ac78371ace2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #23962:
URL: https://github.com/apache/flink/pull/23962#discussion_r1434572736
##########
flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java:
##########
@@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws IOException {
}
@Test
+ @Ignore("FLINK-27082: Fails in Docker with root user")
Review Comment:
Awesome, thanks for making it real :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org