[GitHub] [arrow] xhochy commented on a change in pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

[GitBox <gi...@apache.org>]

xhochy commented on a change in pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#discussion_r554475665



##########
File path: dev/tasks/python-wheels/win-build.bat
##########
@@ -22,11 +22,21 @@
 
 @rem --file=arrow\ci\conda_env_gandiva.yml ^
 
-@rem create conda environment for compiling
 @rem FIXME: Update to numpy 1.16.6
+SET NUMPY_VERSION=1.16.5
+SET VS_VERSION=
+if %PYTHON_VERSION% == 3.6 (
+    @rem When using this variable do not quote it because in batch files
+    @rem quotes are included when rendered.
+    SET VS_VERSION="<14.16"
+) else if %PYTHON_VERSION% == 3.9 (
+    SET NUMPY_VERSION=1.19.5
+)
+
+@rem create conda environment for compiling
 call conda.bat create -n wheel-build -q -y -c conda-forge ^
-    cmake ninja pkg-config numpy=1.16.5 ^
-    "vs2015_runtime<14.16" ^
+    cmake ninja pkg-config numpy=%NUMPY_VERSION% ^

Review comment:
       Can you try this?
   ```suggestion
       cmake ninja pkg-config numpy=%NUMPY_VERSION% libopenssl-static ^
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org