You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2017/02/09 08:32:48 UTC

svn commit: r1782297 - in /myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago: checkstyle-strict.xml checkstyle.xml

Author: lofwyr
Date: Thu Feb  9 08:32:47 2017
New Revision: 1782297

URL: http://svn.apache.org/viewvc?rev=1782297&view=rev
Log:
TOBAGO-1698: Update some build libs
* checkstyle, remove "strict" file and put the difference into the normal file with "TBD" or "TODO" remark

Removed:
    myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle-strict.xml
Modified:
    myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml

Modified: myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml
URL: http://svn.apache.org/viewvc/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml?rev=1782297&r1=1782296&r2=1782297&view=diff
==============================================================================
--- myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml (original)
+++ myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml Thu Feb  9 08:32:47 2017
@@ -174,13 +174,19 @@
         <!-- See http://checkstyle.sf.net/config_coding.html -->
         <!-- <module name="AvoidInlineConditionals"/> -->
         <module name="CovariantEquals"/>
-        <!--<module name="EmptyStatement"/>-->
+        <!-- TBD
+        <module name="EmptyStatement"/>
+        -->
         <module name="EqualsHashCode"/>
-        <!--module name="MissingDeprecated"/-->
-        <!--module name="HiddenField">
+        <!-- TBD
+        <module name="MissingDeprecated"/>
+        -->
+<!-- TBD
+        <module name="HiddenField">
           <property name="ignoreSetter" value="true" />
           <property name=" ignoreConstructorParameter" value="true" />
-        </module-->
+        </module>
+-->
         <module name="IllegalInstantiation">
            <property name="classes" value="java.lang.Boolean, java.lang.String"/>
         </module>
@@ -197,6 +203,9 @@
         <module name="SuperFinalize"/>
         <module name="IllegalThrows"/>
         <module name="PackageDeclaration"/>
+<!-- TODO
+        <module name="DeclarationOrder"/>
+-->
         <module name="ParameterAssignment"/>
         <module name="MultipleVariableDeclarations"/>
         <module name="UnnecessaryParentheses"/>
@@ -214,6 +223,12 @@
         <!-- See http://checkstyle.sf.net/config_misc.html -->
         <module name="ArrayTypeStyle"/>
         <!--<module name="FinalParameters"/> -->
+        <!-- TBD Line with Trailing Spaces (disabled as it's to noisy)
+        <module name="GenericIllegalRegexp">
+          <property name="format" value="\s+$"/>
+          <property name="message" value="Line has trailing spaces."/>
+        </module>
+        -->
 
         <!-- Let todo plugin handle this.
         <module name="TodoComment"/>