You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by David Forsythe <df...@gmail.com> on 2015/12/21 07:23:13 UTC

Review Request 41596: FreeBSD: Fix includes in stout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41596/
-----------------------------------------------------------

Review request for mesos and Ian Downes.


Bugs: MESOS-4212
    https://issues.apache.org/jira/browse/MESOS-4212


Repository: mesos


Description
-------

FreeBSD: Fix includes in stout.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 269e35f56044d250697fe2ffdb181f8bcae64d37 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8cfc77fc30d1bd17f7d3d3b2e8ca449f331aa9ca 

Diff: https://reviews.apache.org/r/41596/diff/


Testing (updated)
-------

gmake check on FreeBSD 10.2-R


Thanks,

David Forsythe

Re: Review Request 41596: FreeBSD: Fix includes in stout.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41596/#review111444
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41596]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 21, 2015, 6:23 a.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41596/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 6:23 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-4212
>     https://issues.apache.org/jira/browse/MESOS-4212
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> FreeBSD: Fix includes in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 269e35f56044d250697fe2ffdb181f8bcae64d37 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8cfc77fc30d1bd17f7d3d3b2e8ca449f331aa9ca 
> 
> Diff: https://reviews.apache.org/r/41596/diff/
> 
> 
> Testing
> -------
> 
> gmake check on FreeBSD 10.2-R
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 41596: FreeBSD: Fix includes in stout.

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41596/#review113304
-----------------------------------------------------------

Ship it!


Ship It!

- Ian Downes


On Dec. 26, 2015, 11:32 a.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41596/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2015, 11:32 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-4212
>     https://issues.apache.org/jira/browse/MESOS-4212
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> FreeBSD: Fix includes in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 269e35f56044d250697fe2ffdb181f8bcae64d37 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8cfc77fc30d1bd17f7d3d3b2e8ca449f331aa9ca 
> 
> Diff: https://reviews.apache.org/r/41596/diff/
> 
> 
> Testing
> -------
> 
> gmake check on FreeBSD 10.2-R
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 41596: FreeBSD: Fix includes in stout.

Posted by David Forsythe <df...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41596/
-----------------------------------------------------------

(Updated Dec. 26, 2015, 7:32 p.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-4212
    https://issues.apache.org/jira/browse/MESOS-4212


Repository: mesos


Description
-------

FreeBSD: Fix includes in stout.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 269e35f56044d250697fe2ffdb181f8bcae64d37 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8cfc77fc30d1bd17f7d3d3b2e8ca449f331aa9ca 

Diff: https://reviews.apache.org/r/41596/diff/


Testing
-------

gmake check on FreeBSD 10.2-R


Thanks,

David Forsythe