You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2016/03/03 02:59:34 UTC

svn commit: r1733406 - in /httpcomponents/httpclient/branches/4.5.x: RELEASE_NOTES.txt httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java

Author: ggregory
Date: Thu Mar  3 01:59:34 2016
New Revision: 1733406

URL: http://svn.apache.org/viewvc?rev=1733406&view=rev
Log:
[HTTPCLIENT-1727] org.apache.http.impl.client.AbstractHttpClient#createClientConnectionManager Does not account for context class loader.

Modified:
    httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt
    httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java

Modified: httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt?rev=1733406&r1=1733405&r2=1733406&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt (original)
+++ httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt Thu Mar  3 01:59:34 2016
@@ -1,3 +1,17 @@
+Release 4.5.3
+-------------------
+
+HttpClient 4.5.3 (GA) is a maintenance release that fixes a number of minor defects found since 4.5.2.
+
+Please note that as of 4.4 HttpClient requires Java 1.6 or newer.
+
+Changelog:
+-------------------
+
+* [HTTPCLIENT-1727] org.apache.http.impl.client.AbstractHttpClient#createClientConnectionManager Does not account for context class loader.
+  Contributed by Charles Allen <charles dot allen at metamarkets dot com>
+
+
 Release 4.5.2
 -------------------
 

Modified: httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java?rev=1733406&r1=1733405&r2=1733406&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java (original)
+++ httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java Thu Mar  3 01:59:34 2016
@@ -327,9 +327,15 @@ public abstract class AbstractHttpClient
 
         final String className = (String) params.getParameter(
                 ClientPNames.CONNECTION_MANAGER_FACTORY_CLASS_NAME);
+        final ClassLoader contextLoader = Thread.currentThread().getContextClassLoader();
         if (className != null) {
             try {
-                final Class<?> clazz = Class.forName(className);
+                final Class<?> clazz;
+                if (contextLoader != null) {
+                    clazz = Class.forName(className, true, contextLoader);
+                } else {
+                    clazz = Class.forName(className);
+                }
                 factory = (ClientConnectionManagerFactory) clazz.newInstance();
             } catch (final ClassNotFoundException ex) {
                 throw new IllegalStateException("Invalid class name: " + className);