You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ul...@apache.org on 2022/02/08 01:24:34 UTC

[incubator-kyuubi] branch branch-1.4 updated: [KYUUBI #1804][FOLLOWUP][GA] Avoid push docker image for forked repos

This is an automated email from the ASF dual-hosted git repository.

ulyssesyou pushed a commit to branch branch-1.4
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/branch-1.4 by this push:
     new 26116da  [KYUUBI #1804][FOLLOWUP][GA] Avoid push docker image for forked repos
26116da is described below

commit 26116da4ac46d51d81b4f0b96a641bb2f79992c7
Author: Fu Chen <cf...@gmail.com>
AuthorDate: Tue Feb 8 09:24:06 2022 +0800

    [KYUUBI #1804][FOLLOWUP][GA] Avoid push docker image for forked repos
    
    <!--
    Thanks for sending a pull request!
    
    Here are some tips for you:
      1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
      2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
      3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
    -->
    
    ### _Why are the changes needed?_
    <!--
    Please clarify why the changes are needed. For instance,
      1. If you add a feature, you can talk about the use case of it.
      2. If you fix a bug, you can clarify why it is a bug.
    -->
    
    ```
    Run docker/login-actionv[1](https://github.com/cfmcgrady/incubator-kyuubi/runs/5088959102?check_suite_focus=true#step:3:1)
      with:
        ecr: auto
        logout: true
    Error: Username and password required
    ```
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #1863 from cfmcgrady/avoid-publish-image.
    
    Closes #1804
    
    5d7711bc [Fu Chen] [GA] avoid push docker image for forked repos
    
    Authored-by: Fu Chen <cf...@gmail.com>
    Signed-off-by: ulysses-you <ul...@apache.org>
    (cherry picked from commit 216560ae425416f29257ef8768077c6db0feafd1)
    Signed-off-by: ulysses-you <ul...@apache.org>
---
 .github/workflows/docker-image.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/docker-image.yml b/.github/workflows/docker-image.yml
index 85c585f..711ee6f 100644
--- a/.github/workflows/docker-image.yml
+++ b/.github/workflows/docker-image.yml
@@ -8,6 +8,7 @@ on:
 jobs:
   push_to_registry:
     name: Push Docker image to Docker Hub
+    if: ${{ startsWith(github.repository, 'apache/') }}
     runs-on: ubuntu-20.04
     concurrency:
       # this group should be global unique