[GitHub] [inlong] healchow commented on a diff in pull request #6155: [INLONG-6154][Manager] Support to get audit data from the ClickHouse

[GitBox <gi...@apache.org>]

healchow commented on code in PR #6155:
URL: https://github.com/apache/inlong/pull/6155#discussion_r993164303


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/ck/ClickhouseConfig.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.service.resource.sink.ck;
+
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.stereotype.Component;
+
+import java.sql.Connection;
+import java.sql.Statement;
+
+/**
+ * Clickhouse config information, including url, user, etc.
+ */
+@Component
+public class ClickhouseConfig {
+
+    @Value("${ck.index.search.url}")
+    private String url;
+
+    @Value("${ck.auth.user}")
+    private String user;
+
+    @Value("${ck.auth.password}")
+    private String password;
+
+    private Statement ckStatement;
+
+    /**
+     * Get ClickHouse statement from config file
+     */
+    public Statement getCkStatement() throws Exception {
+        if (ckStatement == null) {

Review Comment:
   1. This usage seems not thread-safe.
   2. Do we really need a long-time connection for the JDBC statement?



##########
inlong-manager/manager-web/src/main/resources/application-test.properties:
##########
@@ -63,3 +63,11 @@ es.auth.enable=false
 es.auth.user=admin
 # Elasticsearch password of authentication info
 es.auth.password=inlong
+
+# ClickHouse config
+# ClickHouse url
+ck.index.search.url=jdbc:clickhouse://127.0.0.1:8123/apache_inlong_audit

Review Comment:
   Suggested changing to `audit.ck.jdbcUrl`, `audit.ck.username`, `audit.ck.password`.



##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/AuditQuerySource.java:
##########
@@ -28,5 +28,9 @@ public enum AuditQuerySource {
     /**
      * ELASTICSEARCH source of query
      */
-    ELASTICSEARCH;
+    ELASTICSEARCH,
+    /**
+     * ELASTICSEARCH source of query

Review Comment:
   Not `ELASTICSEARCH`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org