You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "demery-pivotal (GitHub)" <gi...@apache.org> on 2019/10/23 17:46:47 UTC

[GitHub] [geode] demery-pivotal commented on pull request #4201: GEODE-7326: Add cache gets timers

I've fixed this in a different way in the metrics session PR. My original code was an unwarranted optimization (caching the ID). Better is to defer fetching the ID until an assertion evaluates it. Given that the first step in each assertion method is to assert that the actual meter is non-null, each assertion method can safely dereference the meter to get the ID.

[ Full content available at: https://github.com/apache/geode/pull/4201 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org