You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/03 04:43:41 UTC

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

ramkrish86 commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r434304341



##########
File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java
##########
@@ -53,6 +53,10 @@
   String COPROCESSOR_EXECUTION_STATISTICS_DESC = "Statistics for coprocessor execution times";
   String REPLICA_ID = "replicaid";
   String REPLICA_ID_DESC = "The replica ID of a region. 0 is primary, otherwise is secondary";
+  String READ_REQUEST_ON_MEMSTORE = "readRequestCountOnMemstore";
+  String READ_REQUEST_ON_MEMSTORE_DESC = "Reads happening out of memstore";
+  String MIXED_READ_REQUEST_ON_STORE = "mixedReadRequestCountOnStore";
+  String MIXED_READ_REQUEST_ON_STORE_DESC = "Reads happening out of files and memstore on store";

Review comment:
       The one above is not needed - MEMSTORE_GET_KEY  and FILE_GET_KEY  in MetricsREgionServerSource because I had removed all those additional metric. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org