[GitHub] [tvm] cbalint13 commented on pull request #7382: Fix missing round(), floor(), ceil() for target C lowering

[GitBox <gi...@apache.org>]

cbalint13 commented on pull request #7382:
URL: https://github.com/apache/tvm/pull/7382#issuecomment-771675620


   @mdw-octoml , @areusch , @manupa-arm 
   
   * Added missing to ```target/intrin_rule.cc``` (as @tqchen suggested).
   * Added test cases to check C lowering.
   * Prepended ```test_``` local funcs of testunit avoiding name conflict with ```<math.h>```
   * C generated code is properly lowered to C function calls:
   ```
   ((float*)B)[(i0)] = ceilf(((float*)A)[(i0)]);
   ((float*)B)[(i0)] = floorf(((float*)A)[(i0)]);
   ((float*)B)[(i0)] = roundf(((float*)A)[(i0)]);
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org