[GitHub] [helix] himanshukandwal commented on a diff in pull request #2586: Add InstanceConfig override for /partitionAssignment API

["himanshukandwal (via GitHub)" <gi...@apache.org>]

himanshukandwal commented on code in PR #2586:
URL: https://github.com/apache/helix/pull/2586#discussion_r1290525815


##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java:
##########
@@ -104,6 +105,8 @@ private static class InputJsonContent {
   }
 
   private static class InstanceChangeMap {
+    @JsonProperty("InstanceConfigs")
+    JsonNode instanceConfigs;

Review Comment:
   As this is a new field, so will there be a case where client might pass json with out this property?
   
   Should we use [JsonIgnoreProperties.html#ignoreUnknown](http://fasterxml.github.io/jackson-annotations/javadoc/2.9/com/fasterxml/jackson/annotation/JsonIgnoreProperties.html#ignoreUnknown() )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org