[GitHub] [brooklyn-server] algairim commented on a change in pull request #1185: when publishing ha health, seems it doesn't update locally

[GitBox <gi...@apache.org>]

algairim commented on a change in pull request #1185:
URL: https://github.com/apache/brooklyn-server/pull/1185#discussion_r648180897



##########
File path: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java
##########
@@ -999,6 +1000,15 @@ public ManagementPlaneSyncRecord loadManagementPlaneSyncRecord(boolean useLocalK
         return record; 
     }
 
+    private boolean updateLastManagementPlaneSyncRecordWithLocalKnowledge() {
+        if (lastSyncRecord!=null) {
+            lastSyncRecord = updateManagementPlaneSyncRecordWithLocalKnowledge(lastSyncRecord);
+            return true;
+        } else {
+            return false;

Review comment:
       Any plans for the return value? Javadoc would help.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org