You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 10:13:52 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #266: Update datafusion-cli dockerfile to be minimalist
Jimexist opened a new pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266
# Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
Closes #.
# Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
# What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
# Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the `breaking change` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #266: Use multi-stage build dockerfile in datafusion-cli and reduce image size from 2.16GB to 89.9MB
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-833302327
I agree with @houqp 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #266: Use multi-stage build dockerfile in datafusion-cli and reduce image size from 2.16GB to 89.9MB
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832585589
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#266](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a82cf2) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/3be087a78846beffdbc4a9f80c73938fa18d24a7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3be087a) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2a82cf2 differs from pull request most recent head d36d768. Consider uploading reports for the commit d36d768 to get more accurate results
[](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #266 +/- ##
=======================================
Coverage 76.21% 76.21%
=======================================
Files 140 140
Lines 23553 23553
=======================================
Hits 17950 17950
Misses 5603 5603
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3be087a...d36d768](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #266: Use multi-stage build dockerfile in datafusion-cli and reduce image size from 2.16GB to 89.9MB
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #266: Use multi-stage build dockerfile in datafusion-cli
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832632592
> I'm not sure whether there are any expectations around CLI performance in Docker, but it's probably worth seeing whether @andygrove's 2020 article on Rust/Alpine perf issues still holds true: https://andygrove.io/2020/05/why-musl-extremely-slow
i guess dropping alpine part of the change is safer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #266: Use multi-stage build dockerfile in datafusion-cli and reduce image size from 2.16GB to 89.9MB
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832803404
Indeed @Jimexist you are correct:
```
docker run -v /tmp:/data -it datafusion-cli
```
works just fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #266: Use multi-stage build dockerfile in datafusion-cli and reduce image size from 2.16GB to 89.9MB
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832791465
```
docker build . -f ./datafusion-cli/Dockerfile -t datafusion-cli
```
And then tried to run the image:
```
docker run -it datafusion-cli
```
I got an error:
```
(arrow_dev) alamb@ip-10-0-0-124:~/Software/arrow-datafusion$ docker run -it datafusion-cli
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/main.rs:56:34
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
Perhaps we need to update the entry point to be `/usr/local/bin/datafusion-cli` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #266: Update datafusion-cli dockerfile to be minimal
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832585589
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#266](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b978bb) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/f7bd7b9f0e5a28b1fada2dbb60151b5af9b16545?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f7bd7b9) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 76.81% 76.87% +0.05%
==========================================
Files 133 133
Lines 23295 23350 +55
==========================================
+ Hits 17895 17950 +55
Misses 5400 5400
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/tests/sql.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi90ZXN0cy9zcWwucnM=) | `99.89% <0.00%> (+<0.01%)` | :arrow_up: |
| [datafusion/src/sql/planner.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvc3FsL3BsYW5uZXIucnM=) | `83.70% <0.00%> (+0.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f7bd7b9...2b978bb](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #266: Update datafusion-cli dockerfile to be minimal
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832585589
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#266](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f8c5d9) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/f7bd7b9f0e5a28b1fada2dbb60151b5af9b16545?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f7bd7b9) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #266 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 133 133
Lines 23295 23295
=======================================
Hits 17895 17895
Misses 5400 5400
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f7bd7b9...0f8c5d9](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #266: Use multi-stage build dockerfile in datafusion-cli and reduce image size from 2.16GB to 89.9MB
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832799135
@alamb I guess you would need to volume map the /data dir. the error message wasn't specific enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #266: Use multi-stage build dockerfile in datafusion-cli and reduce image size from 2.16GB to 89.9MB
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-833293464
minor suggestion not related to this change. i recommend using github container registry instead of dockerhub to host public docker images. dockerhub's rate limit makes it impossible to use the image in any serious production or ci/cd pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] returnString commented on pull request #266: Update datafusion-cli dockerfile to be minimal
Posted by GitBox <gi...@apache.org>.
returnString commented on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832594443
I'm not sure whether there are any expectations around CLI performance in Docker, but it's probably worth seeing whether @andygrove's 2020 article on Rust/Alpine perf issues still holds true: https://andygrove.io/2020/05/why-musl-extremely-slow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #266: Update datafusion-cli dockerfile to be minimalist
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832575668
related #228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #266: Use multi-stage build dockerfile in datafusion-cli and reduce image size from 2.16GB to 89.9MB
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #266:
URL: https://github.com/apache/arrow-datafusion/pull/266#issuecomment-832585589
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#266](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9628b3) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/f7bd7b9f0e5a28b1fada2dbb60151b5af9b16545?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f7bd7b9) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head f9628b3 differs from pull request most recent head 04b9903. Consider uploading reports for the commit 04b9903 to get more accurate results
[](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 76.81% 76.87% +0.05%
==========================================
Files 133 133
Lines 23295 23350 +55
==========================================
+ Hits 17895 17950 +55
Misses 5400 5400
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/src/sql/planner.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvc3FsL3BsYW5uZXIucnM=) | `83.70% <100.00%> (+0.05%)` | :arrow_up: |
| [datafusion/tests/sql.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi90ZXN0cy9zcWwucnM=) | `99.89% <100.00%> (+<0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f7bd7b9...04b9903](https://codecov.io/gh/apache/arrow-datafusion/pull/266?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org