You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/11 12:33:30 UTC
[GitHub] [spark] liucht-inspur opened a new pull request #28799: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column
liucht-inspur opened a new pull request #28799:
URL: https://github.com/apache/spark/pull/28799
What changes were proposed in this pull request?
issue link
https://issues.apache.org/jira/browse/SPARK-31871
this PR link
https://github.com/apache/spark/pull/28680
As @sarutak suggested I open a new PR for branch-2.4
This issue is resolved the sorted list cannot display ICONS
Before：
After：
Why are the changes needed?
The icon could not find the correct path
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Fixed existing test.
history server page:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644552511
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644639301
**[Test build #124109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124109/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644639866
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124109/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644645738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644508863
**[Test build #124086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124086/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644641321
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644555082
**[Test build #124099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124099/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644553331
@liucht-inspur You can't run Jenkins by yourself for now.
If you continue to contribute to Spark, you will be added to the whitelist and be given the right to run Jenkins by saying "retest this please".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] liucht-inspur commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-643008780
> Hi @liucht-inspur , thank you for the contribution.
> If you open a PR for a branch besides `master` , please add a proper tag to the title like `[2.4]` or `[3.0]`.
> Please also see the [contribution guideline](https://spark.apache.org/contributing.html).
Ok, Thanks for your reminding, I will pay more attention next time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28799:
URL: https://github.com/apache/spark/pull/28799#discussion_r440561755
##########
File path: core/src/main/resources/org/apache/spark/ui/static/webui-dataTables.css
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+table.dataTable thead .sorting { background: url('images/sort_both.png') no-repeat bottom right; }
+
+table.dataTable thead .sorting_asc { background: url('images/sort_asc.png') no-repeat bottom right; }
+
+table.dataTable thead .sorting_desc { background: url('images/sort_desc.png') no-repeat bottom right; }
Review comment:
Yes, as the warning suggests.
<img width="704" alt="end-of-line" src="https://user-images.githubusercontent.com/4736016/84727938-1db75f00-afcb-11ea-83df-78aaf2242848.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642616693
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-645502776
Merged to `branch-2.4`.
Thanks @liucht-inspur !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644717976
**[Test build #124117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124117/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644574872
**[Test build #124099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124099/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644552854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644579384
**[Test build #124109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124109/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642984496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] liucht-inspur commented on a change in pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on a change in pull request #28799:
URL: https://github.com/apache/spark/pull/28799#discussion_r440560179
##########
File path: core/src/main/resources/org/apache/spark/ui/static/webui-dataTables.css
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+table.dataTable thead .sorting { background: url('images/sort_both.png') no-repeat bottom right; }
+
+table.dataTable thead .sorting_asc { background: url('images/sort_asc.png') no-repeat bottom right; }
+
+table.dataTable thead .sorting_desc { background: url('images/sort_desc.png') no-repeat bottom right; }
Review comment:
Add just one blank line at the end?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644553331
@liucht-inspur You can't run Jenkins by yourself for now.
If you continue to contribute to Spark, you will be added to the whitelist and given the right to run Jenkins by saying "retest this please".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644645073
**[Test build #124117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124117/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642895344
**[Test build #123863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123863/testReport)** for PR 28799 at commit [`d52ea8e`](https://github.com/apache/spark/commit/d52ea8eee1dd00d1006d7ff61b745b5f1731697e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644509192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644503270
@liucht-inspur Could you reflect my last comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642927083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642984166
**[Test build #123865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123865/testReport)** for PR 28799 at commit [`d52ea8e`](https://github.com/apache/spark/commit/d52ea8eee1dd00d1006d7ff61b745b5f1731697e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644552854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] liucht-inspur commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644549227
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644645073
**[Test build #124117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124117/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642925768
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642927083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642827001
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] liucht-inspur commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644497872
cc @sarutak and @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642926555
**[Test build #123865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123865/testReport)** for PR 28799 at commit [`d52ea8e`](https://github.com/apache/spark/commit/d52ea8eee1dd00d1006d7ff61b745b5f1731697e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644553331
@liucht-inspur You can't run Jenkins by yourself for now.
If you continue to contribute to Spark, you will added to the whitelist and be given the right to run Jenkins by saying "retest this please".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28799:
URL: https://github.com/apache/spark/pull/28799#discussion_r439462266
##########
File path: core/src/main/resources/org/apache/spark/ui/static/webui-dataTables.css
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+table.dataTable thead .sorting { background: url('images/sort_both.png') no-repeat bottom right; }
+
+table.dataTable thead .sorting_asc { background: url('images/sort_asc.png') no-repeat bottom right; }
+
+table.dataTable thead .sorting_desc { background: url('images/sort_desc.png') no-repeat bottom right; }
Review comment:
nit: Could you append a blank line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644509192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644575080
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124099/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644576661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642830058
Hi @liucht-inspur , thank you for the contribution.
If you open a PR for a branch besides `master` , please add a proper tag to the title like `[2.4]` or `[3.0]`.
Please also see the [contribution guideline](https://spark.apache.org/contributing.html).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644579384
**[Test build #124109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124109/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644555082
**[Test build #124099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124099/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642826511
**[Test build #123863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123863/testReport)** for PR 28799 at commit [`d52ea8e`](https://github.com/apache/spark/commit/d52ea8eee1dd00d1006d7ff61b745b5f1731697e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642616102
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644508863
**[Test build #124086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124086/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644541638
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642895894
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123863/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642616693
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644645738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644639855
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642826018
ok to test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642616102
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642926555
**[Test build #123865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123865/testReport)** for PR 28799 at commit [`d52ea8e`](https://github.com/apache/spark/commit/d52ea8eee1dd00d1006d7ff61b745b5f1731697e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644541643
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124086/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644576163
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642984496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644576661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644541195
**[Test build #124086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124086/testReport)** for PR 28799 at commit [`7969e44`](https://github.com/apache/spark/commit/7969e44a0c1de6155d5183717cb2c740094b41e7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642895887
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644575068
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642827001
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644575068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644639855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #28799:
URL: https://github.com/apache/spark/pull/28799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642826511
**[Test build #123863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123863/testReport)** for PR 28799 at commit [`d52ea8e`](https://github.com/apache/spark/commit/d52ea8eee1dd00d1006d7ff61b745b5f1731697e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-642895887
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644718711
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644718711
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28799:
URL: https://github.com/apache/spark/pull/28799#issuecomment-644541638
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org