You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2014/01/08 01:31:33 UTC
Review Request 16711: SENTRY-83: Sentry Solr Tests should have a dependency
on solr-sentry-handlers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16711/
-----------------------------------------------------------
Review request for sentry and Shreepadma Venugopalan.
Repository: sentry
Description
-------
The solr request handlers that are used in the e2e tests (like the QueryIndexAuthorizationComponent) currently live in solr-core, which is a dependency of the test framework. But it is moving shortly to be a contrib called solr-sentry-handlers in order to break the dependency that solr-core has on sentry.
So, we should add this dependency so that nothing breaks when the change goes in.
Diffs
-----
pom.xml e74ef71
sentry-tests/sentry-tests-solr/pom.xml 3f0fa2d
Diff: https://reviews.apache.org/r/16711/diff/
Testing
-------
Ran the e2e tests with the change and they passed.
Thanks,
Gregory Chanan
Re: Review Request 16711: SENTRY-83: Sentry Solr Tests should have a
dependency on solr-sentry-handlers
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16711/#review31326
-----------------------------------------------------------
Ship it!
Ship It!
- Shreepadma Venugopalan
On Jan. 8, 2014, 12:31 a.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16711/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 12:31 a.m.)
>
>
> Review request for sentry and Shreepadma Venugopalan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The solr request handlers that are used in the e2e tests (like the QueryIndexAuthorizationComponent) currently live in solr-core, which is a dependency of the test framework. But it is moving shortly to be a contrib called solr-sentry-handlers in order to break the dependency that solr-core has on sentry.
>
> So, we should add this dependency so that nothing breaks when the change goes in.
>
>
> Diffs
> -----
>
> pom.xml e74ef71
> sentry-tests/sentry-tests-solr/pom.xml 3f0fa2d
>
> Diff: https://reviews.apache.org/r/16711/diff/
>
>
> Testing
> -------
>
> Ran the e2e tests with the change and they passed.
>
>
> Thanks,
>
> Gregory Chanan
>
>