You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by mb...@apache.org on 2012/08/28 22:47:02 UTC
svn commit: r1378321 - in
/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase:
ipc/HBaseRpcMetrics.java regionserver/metrics/RegionServerMetrics.java
Author: mbautin
Date: Tue Aug 28 20:47:01 2012
New Revision: 1378321
URL: http://svn.apache.org/viewvc?rev=1378321&view=rev
Log:
[HBASE-6235] Reset the max and min for HBaseRPCMetrics
Author: liyintang
Summary: Reset the max and min for HBaseRPCMetrics
Test Plan: tested in the ods shadow
Reviewers: kannan, aaiyer
Reviewed By: kannan
CC: hbase-eng@
Differential Revision: https://phabricator.fb.com/D546829
Modified:
hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java?rev=1378321&r1=1378320&r2=1378321&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java Tue Aug 28 20:47:01 2012
@@ -95,15 +95,18 @@ public class HBaseRpcMetrics implements
*/
public void doUpdates(MetricsContext context) {
rpcQueueTime.pushMetric(metricsRecord);
+ rpcQueueTime.resetMinMax();
+
rpcProcessingTime.pushMetric(metricsRecord);
-
+ rpcProcessingTime.resetMinMax();
+
synchronized (registry) {
// Iterate through the registry to propagate the different rpc metrics.
for (String metricName : registry.getKeyList() ) {
MetricsTimeVaryingRate value = (MetricsTimeVaryingRate) registry.get(metricName);
-
value.pushMetric(metricsRecord);
+ value.resetMinMax();
}
}
metricsRecord.update();
Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java?rev=1378321&r1=1378320&r2=1378321&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java Tue Aug 28 20:47:01 2012
@@ -263,10 +263,6 @@ public class RegionServerMetrics impleme
if (this.extendedPeriod > 0 &&
this.lastUpdate - this.lastExtUpdate >= this.extendedPeriod) {
this.lastExtUpdate = this.lastUpdate;
- this.compactionTime.resetMinMaxAvg();
- this.compactionSize.resetMinMaxAvg();
- this.flushTime.resetMinMaxAvg();
- this.flushSize.resetMinMaxAvg();
this.resetAllMinMax();
}
@@ -351,6 +347,10 @@ public class RegionServerMetrics impleme
}
public void resetAllMinMax() {
+ this.compactionTime.resetMinMaxAvg();
+ this.compactionSize.resetMinMaxAvg();
+ this.flushTime.resetMinMaxAvg();
+ this.flushSize.resetMinMaxAvg();
this.atomicIncrementTime.resetMinMax();
this.fsReadLatency.resetMinMax();
this.fsWriteLatency.resetMinMax();