You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by kdubb <gi...@git.apache.org> on 2016/01/17 19:55:29 UTC
[GitHub] thrift pull request: Fix awkward sem-colons & newlines from 3545
GitHub user kdubb opened a pull request:
https://github.com/apache/thrift/pull/797
Fix awkward sem-colons & newlines from 3545
This essentially reverts THRIFT 3545 and uses simpler changes to fix the problem. These changes do not introduce the extra newlines and semi-colons.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reTXT/thrift THRIFT-3559
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/797.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #797
----
commit b6033fd3738c96c3fd93d12d3b8f27d2748d3a1d
Author: Kevin Wooten <ke...@wooten.com>
Date: 2016-01-17T18:53:17Z
Fix awkward sem-colons & newlines from 3545
This essentially reverts THRIFT 3545 with simpler changes that do not introduce the extra newlines and semi-colons.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3559 - Fix awkward sem-colons & newlin...
Posted by kdubb <gi...@git.apache.org>.
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/797#issuecomment-210899860
@Jens-G ??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3559 - Fix awkward sem-colons & newlin...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/797#issuecomment-210906794
kdubb!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3559 - Fix awkward sem-colons & newlin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/797
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---