You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Yaroslav Malyshev (JIRA)" <ji...@apache.org> on 2007/12/15 22:17:43 UTC

[jira] Created: (WICKET-1230) Temporary files not deleting when multipart upload fails with IO error

Temporary files not deleting when multipart upload fails with IO error
----------------------------------------------------------------------

                 Key: WICKET-1230
                 URL: https://issues.apache.org/jira/browse/WICKET-1230
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.0-rc1
            Reporter: Yaroslav Malyshev
            Priority: Critical


I just want to delete temporary files when upload fails (user cancelled or IO error occured), this is really important when uploading files about 500Mb, and this bug makes security hole (anyone can eating my server's disk space by posting incomplete large files).

I can't  find simple workaround, and I think that fix by developers will more easy.

For example you can handle IO error in class org.apache.wicket.util.upload.FileUploadBase, method parseRequest, when IO error occured, just delete all created temporary files, and only after deleting files throw your FileUploadException.

I hope you will fix it soon.
Thanks.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1230) Temporary files not deleting when multipart upload fails with IO error

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1230:
---------------------------------------

    Fix Version/s:     (was: 1.3.0-rc3)
                   1.3.0-final

> Temporary files not deleting when multipart upload fails with IO error
> ----------------------------------------------------------------------
>
>                 Key: WICKET-1230
>                 URL: https://issues.apache.org/jira/browse/WICKET-1230
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Yaroslav Malyshev
>            Assignee: Johan Compagner
>            Priority: Critical
>             Fix For: 1.3.0-final
>
>         Attachments: FileUploadBase.java, FileUploadBase.java.patch
>
>
> I just want to delete temporary files when upload fails (user cancelled or IO error occured), this is really important when uploading files about 500Mb, and this bug makes security hole (anyone can eating my server's disk space by posting incomplete large files).
> I can't  find simple workaround, and I think that fix by developers will more easy.
> For example you can handle IO error in class org.apache.wicket.util.upload.FileUploadBase, method parseRequest, when IO error occured, just delete all created temporary files, and only after deleting files throw your FileUploadException.
> I hope you will fix it soon.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1230) Temporary files not deleting when multipart upload fails with IO error

Posted by "Yaroslav Malyshev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yaroslav Malyshev updated WICKET-1230:
--------------------------------------

    Attachment: FileUploadBase.java

Fixed file with deleting temporary files on error

> Temporary files not deleting when multipart upload fails with IO error
> ----------------------------------------------------------------------
>
>                 Key: WICKET-1230
>                 URL: https://issues.apache.org/jira/browse/WICKET-1230
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Yaroslav Malyshev
>            Priority: Critical
>         Attachments: FileUploadBase.java
>
>
> I just want to delete temporary files when upload fails (user cancelled or IO error occured), this is really important when uploading files about 500Mb, and this bug makes security hole (anyone can eating my server's disk space by posting incomplete large files).
> I can't  find simple workaround, and I think that fix by developers will more easy.
> For example you can handle IO error in class org.apache.wicket.util.upload.FileUploadBase, method parseRequest, when IO error occured, just delete all created temporary files, and only after deleting files throw your FileUploadException.
> I hope you will fix it soon.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1230) Temporary files not deleting when multipart upload fails with IO error

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552246 ] 

Igor Vaynberg commented on WICKET-1230:
---------------------------------------

how about a patch?

> Temporary files not deleting when multipart upload fails with IO error
> ----------------------------------------------------------------------
>
>                 Key: WICKET-1230
>                 URL: https://issues.apache.org/jira/browse/WICKET-1230
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Yaroslav Malyshev
>            Priority: Critical
>         Attachments: FileUploadBase.java
>
>
> I just want to delete temporary files when upload fails (user cancelled or IO error occured), this is really important when uploading files about 500Mb, and this bug makes security hole (anyone can eating my server's disk space by posting incomplete large files).
> I can't  find simple workaround, and I think that fix by developers will more easy.
> For example you can handle IO error in class org.apache.wicket.util.upload.FileUploadBase, method parseRequest, when IO error occured, just delete all created temporary files, and only after deleting files throw your FileUploadException.
> I hope you will fix it soon.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1230) Temporary files not deleting when multipart upload fails with IO error

Posted by "Yaroslav Malyshev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yaroslav Malyshev updated WICKET-1230:
--------------------------------------

    Attachment: FileUploadBase.java.patch

I don't know exactly how to create patches.
I created it with diff program.


> Temporary files not deleting when multipart upload fails with IO error
> ----------------------------------------------------------------------
>
>                 Key: WICKET-1230
>                 URL: https://issues.apache.org/jira/browse/WICKET-1230
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Yaroslav Malyshev
>            Assignee: Johan Compagner
>            Priority: Critical
>             Fix For: 1.3.0-rc3
>
>         Attachments: FileUploadBase.java, FileUploadBase.java.patch
>
>
> I just want to delete temporary files when upload fails (user cancelled or IO error occured), this is really important when uploading files about 500Mb, and this bug makes security hole (anyone can eating my server's disk space by posting incomplete large files).
> I can't  find simple workaround, and I think that fix by developers will more easy.
> For example you can handle IO error in class org.apache.wicket.util.upload.FileUploadBase, method parseRequest, when IO error occured, just delete all created temporary files, and only after deleting files throw your FileUploadException.
> I hope you will fix it soon.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-1230) Temporary files not deleting when multipart upload fails with IO error

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1230.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0-rc3
         Assignee: Johan Compagner

applied

> Temporary files not deleting when multipart upload fails with IO error
> ----------------------------------------------------------------------
>
>                 Key: WICKET-1230
>                 URL: https://issues.apache.org/jira/browse/WICKET-1230
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Yaroslav Malyshev
>            Assignee: Johan Compagner
>            Priority: Critical
>             Fix For: 1.3.0-rc3
>
>         Attachments: FileUploadBase.java
>
>
> I just want to delete temporary files when upload fails (user cancelled or IO error occured), this is really important when uploading files about 500Mb, and this bug makes security hole (anyone can eating my server's disk space by posting incomplete large files).
> I can't  find simple workaround, and I think that fix by developers will more easy.
> For example you can handle IO error in class org.apache.wicket.util.upload.FileUploadBase, method parseRequest, when IO error occured, just delete all created temporary files, and only after deleting files throw your FileUploadException.
> I hope you will fix it soon.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1230) Temporary files not deleting when multipart upload fails with IO error

Posted by "Yaroslav Malyshev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yaroslav Malyshev updated WICKET-1230:
--------------------------------------

    Comment: was deleted

> Temporary files not deleting when multipart upload fails with IO error
> ----------------------------------------------------------------------
>
>                 Key: WICKET-1230
>                 URL: https://issues.apache.org/jira/browse/WICKET-1230
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Yaroslav Malyshev
>            Priority: Critical
>         Attachments: FileUploadBase.java
>
>
> I just want to delete temporary files when upload fails (user cancelled or IO error occured), this is really important when uploading files about 500Mb, and this bug makes security hole (anyone can eating my server's disk space by posting incomplete large files).
> I can't  find simple workaround, and I think that fix by developers will more easy.
> For example you can handle IO error in class org.apache.wicket.util.upload.FileUploadBase, method parseRequest, when IO error occured, just delete all created temporary files, and only after deleting files throw your FileUploadException.
> I hope you will fix it soon.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1230) Temporary files not deleting when multipart upload fails with IO error

Posted by "Yaroslav Malyshev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552173 ] 

Yaroslav Malyshev commented on WICKET-1230:
-------------------------------------------

I attached my fixed file

> Temporary files not deleting when multipart upload fails with IO error
> ----------------------------------------------------------------------
>
>                 Key: WICKET-1230
>                 URL: https://issues.apache.org/jira/browse/WICKET-1230
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Yaroslav Malyshev
>            Priority: Critical
>         Attachments: FileUploadBase.java
>
>
> I just want to delete temporary files when upload fails (user cancelled or IO error occured), this is really important when uploading files about 500Mb, and this bug makes security hole (anyone can eating my server's disk space by posting incomplete large files).
> I can't  find simple workaround, and I think that fix by developers will more easy.
> For example you can handle IO error in class org.apache.wicket.util.upload.FileUploadBase, method parseRequest, when IO error occured, just delete all created temporary files, and only after deleting files throw your FileUploadException.
> I hope you will fix it soon.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.