You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ZihanLi58 (via GitHub)" <gi...@apache.org> on 2023/08/08 23:25:37 UTC
[GitHub] [gobblin] ZihanLi58 opened a new pull request, #3734: [GOBBLIN-1871] Fix bug that hiveMetadataWriter may make the hive schema columns inconsistent with the Avro.schema.literal
ZihanLi58 opened a new pull request, #3734:
URL: https://github.com/apache/gobblin/pull/3734
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1871
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
hiveMetadataWriter might update Avro.schema.literal without making the corresponding change in hive schema columns
Also change the HiveOrcSerDeManager to only talk with hdfs when necessary to reduce the num of call to hdfs.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
unit tested
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 merged pull request #3734: [GOBBLIN-1871] Fix bug that hiveMetadataWriter may make the hive schema columns inconsistent with the Avro.schema.literal
Posted by "ZihanLi58 (via GitHub)" <gi...@apache.org>.
ZihanLi58 merged PR #3734:
URL: https://github.com/apache/gobblin/pull/3734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3734: [GOBBLIN-1871] Fix bug that hiveMetadataWriter may make the hive schema columns inconsistent with the Avro.schema.literal
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3734:
URL: https://github.com/apache/gobblin/pull/3734#issuecomment-1670451034
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3734](https://app.codecov.io/gh/apache/gobblin/pull/3734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3783ecb) into [master](https://app.codecov.io/gh/apache/gobblin/commit/0d3b3b544efac7647094a131f9c8947351d40511?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0d3b3b5) will **decrease** coverage by `1.76%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3734 +/- ##
============================================
- Coverage 47.08% 45.33% -1.76%
+ Complexity 10860 2138 -8722
============================================
Files 2146 413 -1733
Lines 84783 17956 -66827
Branches 9409 2184 -7225
============================================
- Hits 39920 8140 -31780
+ Misses 41240 8949 -32291
+ Partials 3623 867 -2756
```
[see 1733 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3734/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] vikrambohra commented on pull request #3734: [GOBBLIN-1871] Fix bug that hiveMetadataWriter may make the hive schema columns inconsistent with the Avro.schema.literal
Posted by "vikrambohra (via GitHub)" <gi...@apache.org>.
vikrambohra commented on PR #3734:
URL: https://github.com/apache/gobblin/pull/3734#issuecomment-1671994905
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org