[incubator-celeborn] branch main updated: [CELEBORN-394] Refine memory manager's log. (#1332)

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhouky pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 238521557 [CELEBORN-394] Refine memory manager's log. (#1332)
238521557 is described below

commit 23852155789e0da98f77ee18b36059544fa980c6
Author: Ethan Feng <et...@apache.org>
AuthorDate: Mon Mar 13 15:13:33 2023 +0800

    [CELEBORN-394] Refine memory manager's log. (#1332)
---
 .../common/network/server/memory/MemoryManager.java       | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/common/src/main/java/org/apache/celeborn/common/network/server/memory/MemoryManager.java b/common/src/main/java/org/apache/celeborn/common/network/server/memory/MemoryManager.java
index 3bb9cdaef..c1da7f25f 100644
--- a/common/src/main/java/org/apache/celeborn/common/network/server/memory/MemoryManager.java
+++ b/common/src/main/java/org/apache/celeborn/common/network/server/memory/MemoryManager.java
@@ -160,6 +160,8 @@ public class MemoryManager {
             MemoryManagerStat lastAction = memoryManagerStat;
             memoryManagerStat = currentMemoryAction();
             if (lastAction != memoryManagerStat) {
+              logger.info(
+                  "Memory manager actions transformed {} -> {}", lastAction, memoryManagerStat);
               if (memoryManagerStat == MemoryManagerStat.pausePushDataAndResumeReplicate) {
                 pausePushDataCounter.increment();
                 actionService.submit(
@@ -203,7 +205,7 @@ public class MemoryManager {
                   actionService.submit(
                       () -> {
                         try {
-                          logger.info("Trigger trim action");
+                          logger.debug("Trigger trim action");
                           memoryPressureListeners.forEach(MemoryPressureListener::onTrim);
                         } finally {
                           trimInProcess.set(false);
@@ -223,11 +225,12 @@ public class MemoryManager {
     reportService.scheduleWithFixedDelay(
         () ->
             logger.info(
-                "Direct memory usage: {}/{}, disk buffer size: {}, sort memory size: {}",
+                "Direct memory usage: {}/{}, disk buffer size: {}, sort memory size: {}, read buffer size: {}",
                 Utils.bytesToString(nettyMemoryCounter.get()),
                 Utils.bytesToString(maxDirectorMemory),
                 Utils.bytesToString(diskBufferCounter.get()),
-                Utils.bytesToString(sortMemoryCounter.get())),
+                Utils.bytesToString(sortMemoryCounter.get()),
+                Utils.bytesToString(readBufferCounter.get())),
         reportInterval,
         reportInterval,
         TimeUnit.SECONDS);
@@ -237,11 +240,13 @@ public class MemoryManager {
     logger.info(
         "Memory tracker initialized with: "
             + "max direct memory: {}, pause pushdata memory: {}, "
-            + "pause replication memory: {}, resume memory: {}",
+            + "pause replication memory: {}, resume memory: {},"
+            + "read buffer memory limit: {}",
         Utils.bytesToString(maxDirectorMemory),
         Utils.bytesToString(pausePushDataThreshold),
         Utils.bytesToString(pauseReplicateThreshold),
-        Utils.bytesToString(resumeThreshold));
+        Utils.bytesToString(resumeThreshold),
+        Utils.bytesToString(readBufferThreshold));
   }
 
   private void initDirectMemoryIndicator() {