[GitHub] [arrow] pitrou commented on a change in pull request #9887: ARROW-12202: [Rust] WIP Fix SEGFAULT/ SIGILL in child-data ffi

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #9887:
URL: https://github.com/apache/arrow/pull/9887#discussion_r607941015



##########
File path: rust/arrow/src/ffi.rs
##########
@@ -135,13 +140,14 @@ impl FFI_ArrowSchema {
         let n_children = children.len() as i64;
         let children_ptr = children.as_ptr() as *mut *mut FFI_ArrowSchema;
 
-        let flags = if nullable { 2 } else { 0 };
+        let flags = if nullable { FLAG_NULLABLE } else { FLAG_NONE };
 
         let private_data = Box::new(SchemaPrivateData { children });
         // <https://arrow.apache.org/docs/format/CDataInterface.html#c.ArrowSchema>
         FFI_ArrowSchema {
             format: CString::new(format).unwrap().into_raw(),
-            // For child data a non null string is expected and is called item
+            // TODO: get the field name for general nested data
+            // For List child data a non null string is expected and is called item
             name: CString::new("item").unwrap().into_raw(),

Review comment:
       This should be released in `release_schema`, like `format` already is.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org