You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2004/10/14 18:26:27 UTC
Re: svn commit: r11364 - trunk/subversion/libsvn_fs_fs
bliss@tigris.org writes:
> (svn_fs_fs__write_revision_zero): Create an empty revprop file for
> revision zero.
I should have asked this before, but I didn't spot it then, sorry:
> --- trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
> +++ trunk/subversion/libsvn_fs_fs/fs_fs.c Wed Oct 13 14:56:07 2004
> @@ -3642,6 +3659,8 @@
> "2d2977d1c96f487abe4a1e202dd03b4e\n"
> "cpath: /\n"
> "\n\n17 107\n", pool));
> +
> + SVN_ERR (svn_io_file_create (path_revprops (fs, 0, pool), "", pool));
>
> return SVN_NO_ERROR;
> }
In BDB repositories, r0 has an 'svn:date' property, with a value of
the time the repository was created. Is there some reason for FSFS
repositories to be different?
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r11364 - trunk/subversion/libsvn_fs_fs
Posted by Tobias Ringström <to...@ringstrom.mine.nu>.
Greg Hudson wrote:
>On Thu, 2004-10-14 at 14:26, kfogel@collab.net wrote:
>
>
>>>+ SVN_ERR (svn_io_file_create (path_revprops (fs, 0, pool), "", pool));
>>>
>>>
>>In BDB repositories, r0 has an 'svn:date' property, with a value of
>>the time the repository was created. Is there some reason for FSFS
>>repositories to be different?
>>
>>
No, the date revprop was added later at a higher level, but while fixing
the bug pointed out by ghudson below, I've moved the revprop creation
back to where svn:date is set.
>Oh, also, an empty file is not a valid hash representation. It is
>accepted by svn_hash_read() as an implementation artifact, but not by
>svn_hash_read2() (I was sloppy and did not update all the calls to
>svn_hash_read()). There needs to be an "END\n" in there.
>
>
That's a bug. I've fixed this in r11410. Thanks!
/Tobias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r11364 - trunk/subversion/libsvn_fs_fs
Posted by Greg Hudson <gh...@MIT.EDU>.
On Thu, 2004-10-14 at 14:26, kfogel@collab.net wrote:
> > + SVN_ERR (svn_io_file_create (path_revprops (fs, 0, pool), "", pool));
> In BDB repositories, r0 has an 'svn:date' property, with a value of
> the time the repository was created. Is there some reason for FSFS
> repositories to be different?
Oh, also, an empty file is not a valid hash representation. It is
accepted by svn_hash_read() as an implementation artifact, but not by
svn_hash_read2() (I was sloppy and did not update all the calls to
svn_hash_read()). There needs to be an "END\n" in there.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org