[GitHub] [arrow-datafusion] Jimexist commented on pull request #571: Collapse sort into window expr and do sort within logical phase

[GitBox <gi...@apache.org>]

Jimexist commented on pull request #571:
URL: https://github.com/apache/arrow-datafusion/pull/571#issuecomment-865010150


   performance comparison:
   
   ```
   Benchmarking window empty over, aggregate functions: Warming up for 3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.6s, enable flat sampling, or reduce sample count to 50.
   window empty over, aggregate functions
                           time:   [1.8359 ms 1.8475 ms 1.8610 ms]
                           change: [-0.9132% +0.5180% +2.1212%] (p = 0.50 > 0.05)
                           No change in performance detected.
   Found 11 outliers among 100 measurements (11.00%)
     7 (7.00%) high mild
     4 (4.00%) high severe
   
   Benchmarking window empty over, built-in functions: Warming up for 3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.0s, enable flat sampling, or reduce sample count to 50.
   window empty over, built-in functions
                           time:   [1.3685 ms 1.3760 ms 1.3844 ms]
                           change: [-4.4221% -2.8960% -1.5378%] (p = 0.00 < 0.05)
                           Performance has improved.
   Found 7 outliers among 100 measurements (7.00%)
     4 (4.00%) high mild
     3 (3.00%) high severe
   
   window order by, aggregate functions
                           time:   [8.1463 ms 8.2384 ms 8.3348 ms]
                           change: [-4.8125% -3.2407% -1.6147%] (p = 0.00 < 0.05)
                           Performance has improved.
   
   window order by, built-in functions
                           time:   [7.4629 ms 7.5195 ms 7.5799 ms]
                           change: [-0.3291% +0.5924% +1.5385%] (p = 0.23 > 0.05)
                           No change in performance detected.
   Found 3 outliers among 100 measurements (3.00%)
     2 (2.00%) high mild
     1 (1.00%) high severe
   
   window partition by, u64_wide, aggregate functions
                           time:   [18.755 ms 18.945 ms 19.140 ms]
                           change: [+4.0084% +5.3579% +6.5762%] (p = 0.00 < 0.05)
                           Performance has regressed.
   Found 1 outliers among 100 measurements (1.00%)
     1 (1.00%) high mild
   
   window partition by, u64_narrow, aggregate functions
                           time:   [6.3792 ms 6.4266 ms 6.4811 ms]
                           change: [-2.6467% -1.6117% -0.4429%] (p = 0.00 < 0.05)
                           Change within noise threshold.
   Found 4 outliers among 100 measurements (4.00%)
     1 (1.00%) high mild
     3 (3.00%) high severe
   
   window partition by, u64_wide, built-in functions
                           time:   [16.257 ms 16.400 ms 16.551 ms]
                           change: [-0.1608% +0.9364% +2.1068%] (p = 0.11 > 0.05)
                           No change in performance detected.
   Found 7 outliers among 100 measurements (7.00%)
     7 (7.00%) high mild
   
   window partition by, u64_narrow, built-in functions
                           time:   [5.9251 ms 5.9624 ms 6.0024 ms]
                           change: [+0.8259% +1.7545% +2.7146%] (p = 0.00 < 0.05)
                           Change within noise threshold.
   Found 2 outliers among 100 measurements (2.00%)
     2 (2.00%) high mild
   
   window partition and order by, u64_wide, aggregate functions
                           time:   [24.977 ms 25.136 ms 25.308 ms]
                           change: [-2.8450% -1.7267% -0.6014%] (p = 0.00 < 0.05)
                           Change within noise threshold.
   Found 2 outliers among 100 measurements (2.00%)
     2 (2.00%) high mild
   
   Benchmarking window partition and order by, u64_narrow, aggregate functions: Warming up for 3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.4s, or reduce sample count to 90.
   window partition and order by, u64_narrow, aggregate functions
                           time:   [54.278 ms 54.907 ms 55.598 ms]
                           change: [+0.8203% +2.1981% +3.7199%] (p = 0.00 < 0.05)
                           Change within noise threshold.
   Found 13 outliers among 100 measurements (13.00%)
     6 (6.00%) high mild
     7 (7.00%) high severe
   
   window partition and order by, u64_wide, built-in functions
                           time:   [23.541 ms 23.740 ms 23.949 ms]
                           change: [-1.1173% +0.2109% +1.4568%] (p = 0.74 > 0.05)
                           No change in performance detected.
   Found 7 outliers among 100 measurements (7.00%)
     7 (7.00%) high mild
   
   window partition and order by, u64_narrow, built-in functions
                           time:   [15.821 ms 15.958 ms 16.103 ms]
                           change: [+0.3405% +1.5444% +2.6931%] (p = 0.01 < 0.05)
                           Change within noise threshold.
   Found 2 outliers among 100 measurements (2.00%)
     2 (2.00%) high mild
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org