You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2017/09/10 16:38:26 UTC
[GitHub] zeppelin pull request #2578: [ZEPPELIN-2921] does not work conda environment...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/2578
[ZEPPELIN-2921] does not work conda environment in python interpreter
### What is this PR for?
It seems that the environment of the python interpreter has changed to the py4j environment, causing problems with the library path and the default environment.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2921
### How should this be tested?
Please run the following command line for each paragraph.
If the module such as scipy is normally imported, it is a success.
`%python.conda create --name Hello6 python=2.7`
`%python.conda activate Hello6`
`%python.conda install seaborn pandas numpy scipy matplotlib`
```
%python
import scipy as sp
import seaborn as sns
```
`%python.conda deactivate`
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2921
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2578
----
commit 8dfb33b1159695e109a696c38a3fd6a112a79e13
Author: CloverHearts <cl...@gmail.com>
Date: 2017-09-10T16:36:19Z
replace conda install environment name
----
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
LGTM.
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@1ambda @zjffdu @felixcheung
Sorry.
I divided the existing PR by the minimum function.
Can you review this PR again?
Thank you for your help :)
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Thanks @cloverhearts , Is it possible to add unit test for `PythonCondaInterpreter` ? Regarding the CI failure, I know this failure and will fix it in another PR
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@zjffdu Thank you a lot :)
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Checked that `conda list` works beautifully. But I am getting this ipython related message when activate a new env. Can we remove this message which is not related to conda at all.
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@zjffdu I created one. Thanks.
- https://issues.apache.org/jira/browse/ZEPPELIN-2923
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
fixed test case and conda list feature
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@1ambda okay :)
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@1ambda This is due to IPythonInterpreter, could create a ticket ? I will fix it in another PR.
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@zjffdu Sure, Thank you :)
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Tested locally and works well. @cloverhearts Can we fix `conda list` command as well? it will need exactly the same code with `conda install`.
LGTM except for it.
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
LGTM, just one concern about `PythonCondaInterpreterTest.java`. It is using mock which may not found potential bugs. I think we can do unit without mock. But anyway this could be done in a following up ticket.
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
If there are no comments anymore, I will merge to master on this pr.
---
[GitHub] zeppelin pull request #2578: [ZEPPELIN-2921] does not work conda environment...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2578
---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
The problem of CI is irrelevant to this pr.
```
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.462 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest
testStartStop(org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest) Time elapsed: 10.043 sec <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest.testStartStop(RemoteInterpreterServerTest.java:62)
```
---