You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/02/05 03:45:08 UTC

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10343: Polish aws-firehose-receiver to adapt existing OTEL proto

kezhenxu94 commented on code in PR #10343:
URL: https://github.com/apache/skywalking/pull/10343#discussion_r1096618154


##########
oap-server/server-receiver-plugin/aws-firehose-receiver/README.MD:
##########
@@ -0,0 +1,7 @@
+### Notice
+The OTEL proto in this module copy from [opentelemetry-proto v0.7.0](https://github.com/open-telemetry/opentelemetry-proto/tree/v0.7.0) as AWS firehose only support OTEL 0.7, and rewrite follows :

Review Comment:
   > AWS firehose only support OTEL 0.7
   
   What does this mean? Does it mean the https://github.com/apache/skywalking/pull/10300 doesn't work at all or anything else?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org