You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/08/29 21:55:38 UTC

[jira] [Created] (HBASE-4281) Add facility to dump current state of all executors

Add facility to dump current state of all executors
---------------------------------------------------

                 Key: HBASE-4281
                 URL: https://issues.apache.org/jira/browse/HBASE-4281
             Project: HBase
          Issue Type: New Feature
          Components: master, regionserver, util
    Affects Versions: 0.92.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon
             Fix For: 0.92.0


For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4281) Add facility to dump current state of all executors

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-4281:
-------------------------------

    Attachment: 0006-HBASE-4281.-ExecutorService-monitoring.patch

Patch adds monitoring to the generic ExecutorService.

This monitoring gets exposed to the user as part of HBASE-4292

> Add facility to dump current state of all executors
> ---------------------------------------------------
>
>                 Key: HBASE-4281
>                 URL: https://issues.apache.org/jira/browse/HBASE-4281
>             Project: HBase
>          Issue Type: New Feature
>          Components: master, regionserver, util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.0
>
>         Attachments: 0006-HBASE-4281.-ExecutorService-monitoring.patch
>
>
> For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Work started] (HBASE-4281) Add facility to dump current state of all executors

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on HBASE-4281 started by Todd Lipcon.

> Add facility to dump current state of all executors
> ---------------------------------------------------
>
>                 Key: HBASE-4281
>                 URL: https://issues.apache.org/jira/browse/HBASE-4281
>             Project: HBase
>          Issue Type: New Feature
>          Components: master, regionserver, util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.0
>
>         Attachments: 0006-HBASE-4281.-ExecutorService-monitoring-v2.patch, 0006-HBASE-4281.-ExecutorService-monitoring.patch, hbase-4281-v3.txt, hbase-4281-v4.txt
>
>
> For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4281) Add facility to dump current state of all executors

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-4281:
-------------------------------

    Attachment: hbase-4281-v4.txt

Final patch with some javadoc and more wrapping.

> Add facility to dump current state of all executors
> ---------------------------------------------------
>
>                 Key: HBASE-4281
>                 URL: https://issues.apache.org/jira/browse/HBASE-4281
>             Project: HBase
>          Issue Type: New Feature
>          Components: master, regionserver, util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.0
>
>         Attachments: 0006-HBASE-4281.-ExecutorService-monitoring-v2.patch, 0006-HBASE-4281.-ExecutorService-monitoring.patch, hbase-4281-v3.txt, hbase-4281-v4.txt
>
>
> For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4281) Add facility to dump current state of all executors

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-4281:
-------------------------------

    Attachment: hbase-4281-v3.txt

Accidentally was missing one of the new files (ThreadMonitoring.java) in the previous patch. Can you take another look, Stack?

> Add facility to dump current state of all executors
> ---------------------------------------------------
>
>                 Key: HBASE-4281
>                 URL: https://issues.apache.org/jira/browse/HBASE-4281
>             Project: HBase
>          Issue Type: New Feature
>          Components: master, regionserver, util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.0
>
>         Attachments: 0006-HBASE-4281.-ExecutorService-monitoring-v2.patch, 0006-HBASE-4281.-ExecutorService-monitoring.patch, hbase-4281-v3.txt
>
>
> For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4281) Add facility to dump current state of all executors

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-4281:
-------------------------------

    Attachment: 0006-HBASE-4281.-ExecutorService-monitoring-v2.patch

I'd used some 0.90 types in the previous patch. This one is trunk-safe. I'll try to run some tests on the whole trunk with the whole patch series before committing.

> Add facility to dump current state of all executors
> ---------------------------------------------------
>
>                 Key: HBASE-4281
>                 URL: https://issues.apache.org/jira/browse/HBASE-4281
>             Project: HBase
>          Issue Type: New Feature
>          Components: master, regionserver, util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.0
>
>         Attachments: 0006-HBASE-4281.-ExecutorService-monitoring-v2.patch, 0006-HBASE-4281.-ExecutorService-monitoring.patch
>
>
> For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4281) Add facility to dump current state of all executors

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093985#comment-13093985 ] 

Jean-Daniel Cryans commented on HBASE-4281:
-------------------------------------------

+1

A trickle of javadoc on public methods missing them would be good if you want to do that on commit, along with fixing a few of those long lines.

> Add facility to dump current state of all executors
> ---------------------------------------------------
>
>                 Key: HBASE-4281
>                 URL: https://issues.apache.org/jira/browse/HBASE-4281
>             Project: HBase
>          Issue Type: New Feature
>          Components: master, regionserver, util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.0
>
>         Attachments: 0006-HBASE-4281.-ExecutorService-monitoring-v2.patch, 0006-HBASE-4281.-ExecutorService-monitoring.patch, hbase-4281-v3.txt
>
>
> For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4281) Add facility to dump current state of all executors

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093391#comment-13093391 ] 

stack commented on HBASE-4281:
------------------------------

Looks fine to me.  +1 on commit.

> Add facility to dump current state of all executors
> ---------------------------------------------------
>
>                 Key: HBASE-4281
>                 URL: https://issues.apache.org/jira/browse/HBASE-4281
>             Project: HBase
>          Issue Type: New Feature
>          Components: master, regionserver, util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.0
>
>         Attachments: 0006-HBASE-4281.-ExecutorService-monitoring.patch
>
>
> For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-4281) Add facility to dump current state of all executors

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon resolved HBASE-4281.
--------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]

Committed to trunk.

> Add facility to dump current state of all executors
> ---------------------------------------------------
>
>                 Key: HBASE-4281
>                 URL: https://issues.apache.org/jira/browse/HBASE-4281
>             Project: HBase
>          Issue Type: New Feature
>          Components: master, regionserver, util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.0
>
>         Attachments: 0006-HBASE-4281.-ExecutorService-monitoring-v2.patch, 0006-HBASE-4281.-ExecutorService-monitoring.patch, hbase-4281-v3.txt, hbase-4281-v4.txt
>
>
> For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4281) Add facility to dump current state of all executors

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094150#comment-13094150 ] 

Hudson commented on HBASE-4281:
-------------------------------

Integrated in HBase-TRUNK #2162 (See [https://builds.apache.org/job/HBase-TRUNK/2162/])
    HBASE-4281  Add facility to dump current state of all executors

todd : 
Files : 
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/monitoring/ThreadMonitoring.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java


> Add facility to dump current state of all executors
> ---------------------------------------------------
>
>                 Key: HBASE-4281
>                 URL: https://issues.apache.org/jira/browse/HBASE-4281
>             Project: HBase
>          Issue Type: New Feature
>          Components: master, regionserver, util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.0
>
>         Attachments: 0006-HBASE-4281.-ExecutorService-monitoring-v2.patch, 0006-HBASE-4281.-ExecutorService-monitoring.patch, hbase-4281-v3.txt, hbase-4281-v4.txt
>
>
> For debugging, it's useful to be able to understand the current state of all of the executors. This is like the /stacks servlet, but with executor-specific information, including what's queued and not yet running.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira