You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/11 21:00:59 UTC

[GitHub] [arrow-datafusion] alamb commented on pull request #6632: Fix date_trunc signature

alamb commented on PR #6632:
URL: https://github.com/apache/arrow-datafusion/pull/6632#issuecomment-1586335712

   After reviewing https://github.com/apache/arrow-datafusion/pull/6638 from @viirya  I am not sure about this PR anymore -- it seems like this PR simply makes the signature match for the array versions but then it would be inconsistent with the scalar versions...
   
   I think any real fix should have the array and scalar implementations match and of course the signature match 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org