You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2018/06/20 18:35:00 UTC
[jira] [Commented] (HBASE-20762) precommit should archive generated
LICENSE file
[ https://issues.apache.org/jira/browse/HBASE-20762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518459#comment-16518459 ]
Sean Busbey commented on HBASE-20762:
-------------------------------------
our jenkins job tries to do this now, here's our Archive artifacts:
{code}
patchprocess/*, patchprocess/**/*,**/LICENSE,**/NOTICE
{code}
Probably we should change the list of things we tell yetus to save. YETUS_ARGS parameter has {{--archive-list=rat.txt}} and we should update that to include LICENSE and NOTICE.
> precommit should archive generated LICENSE file
> -----------------------------------------------
>
> Key: HBASE-20762
> URL: https://issues.apache.org/jira/browse/HBASE-20762
> Project: HBase
> Issue Type: Bug
> Components: build, community
> Reporter: Mike Drob
> Priority: Major
>
> When a precommit run fails due to license issues, we get pointed to a file in our maven logs:
> {noformat}
> /testptch/hbase/hbase-assembly/target/maven-shared-archive-resources/META-INF/LICENSE
> {noformat}
> But we don't have that file saved, so we don't know what the actual failure was. So we should save that in our build artifacts. Or maybe we can print a snippet from that file directly into the maven log. Both would be acceptable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)