[GitHub] [pulsar] lifepuzzlefun commented on a diff in pull request #20512: [fix][broker] fix `ModularLoadManagerImpl` always delete bundle-data from metadata store logic.

["lifepuzzlefun (via GitHub)" <gi...@apache.org>]

lifepuzzlefun commented on code in PR #20512:
URL: https://github.com/apache/pulsar/pull/20512#discussion_r1223127765


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -198,6 +199,10 @@ public class ModularLoadManagerImpl implements ModularLoadManager {
     private final Set<String> knownBrokers = new HashSet<>();
     private Map<String, String> bundleBrokerAffinityMap;
 
+    public static long nonActiveBundleDeleteThreshold = 15;

Review Comment:
   why this threshold is needed ? sometimes a bundle is not loaded in this load report round. so a threshold is just to protect bundle not to be deleted for this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org