You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/07/24 05:04:17 UTC

[PR] [Studio] Fix ACL page API integration [rocketmq-dashboard]

Aias00 opened a new pull request, #516:
URL: https://github.com/apache/rocketmq-dashboard/pull/516

   ### Motivation
   The Studio ACL management page was still backed by local mock data, so ACL rule/user changes were not persisted through the backend APIs. This blocks the AUTH-01/Base ACL management path from working as a real control-plane page.
   
   ### Changes
   - Load ACL rules and users from the service/API layer instead of static mock arrays.
   - Add backend update endpoints for ACL rules and users.
   - Wire create/update/delete/toggle-admin actions to backend APIs with loading and error states.
   - Add frontend API/page tests and backend controller/service tests for the new update flow.
   
   ### Verification
   - `JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -B -ntp -Dtest=AclControllerTest,AclServiceTest test`
   - `JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -B -ntp test`
   - `npm test -- acl.test.ts AclPage.test.tsx`
   - `npm run lint`
   - `npm run build`
   
   Note: `npm test` for the whole web package still has unrelated existing failures in `ops.test.ts` and `BrokerCluster.test.tsx`; the ACL-targeted tests pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Studio] Fix ACL page API integration [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #516:
URL: https://github.com/apache/rocketmq-dashboard/pull/516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org