You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/21 01:46:00 UTC
[GitHub] [airflow] potiuk opened a new pull request #7224: [AIRFLOW-6603]
Remove unnecessary pylint warnings
potiuk opened a new pull request #7224: [AIRFLOW-6603] Remove unnecessary pylint warnings
URL: https://github.com/apache/airflow/pull/7224
There are unnecessary pylint warnings in ODBC that are
spamming the error messages. We need to silence the.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7224: [AIRFLOW-6603] Remove
unnecessary pylint warnings
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7224: [AIRFLOW-6603] Remove unnecessary pylint warnings
URL: https://github.com/apache/airflow/pull/7224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7224:
[AIRFLOW-6603] Remove unnecessary pylint warnings
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7224: [AIRFLOW-6603] Remove unnecessary pylint warnings
URL: https://github.com/apache/airflow/pull/7224#issuecomment-576491412
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=h1) Report
> Merging [#7224](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b44c0fc4ac0030c78ab6ad4e658e9abdf60dc04?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7224 +/- ##
=========================================
- Coverage 85.53% 85.23% -0.3%
=========================================
Files 756 758 +2
Lines 39859 39932 +73
=========================================
- Hits 34094 34038 -56
- Misses 5765 5894 +129
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/odbc/hooks/odbc.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb2RiYy9ob29rcy9vZGJjLnB5) | `92.22% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/api/client/local\_client.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2xvY2FsX2NsaWVudC5weQ==) | `92% <0%> (-8%)` | :arrow_down: |
| [airflow/api/client/api\_client.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2FwaV9jbGllbnQucHk=) | `63.15% <0%> (-1.55%)` | :arrow_down: |
| [airflow/lineage/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9saW5lYWdlL19faW5pdF9fLnB5) | `93.84% <0%> (ø)` | :arrow_up: |
| [airflow/api/client/json\_client.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2pzb25fY2xpZW50LnB5) | `0% <0%> (ø)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=footer). Last update [5b44c0f...933319f](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7224: [AIRFLOW-6603]
Remove unnecessary pylint warnings
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7224: [AIRFLOW-6603] Remove unnecessary pylint warnings
URL: https://github.com/apache/airflow/pull/7224#issuecomment-576491412
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=h1) Report
> Merging [#7224](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b44c0fc4ac0030c78ab6ad4e658e9abdf60dc04?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7224 +/- ##
=========================================
- Coverage 85.53% 85.23% -0.3%
=========================================
Files 756 758 +2
Lines 39859 39932 +73
=========================================
- Hits 34094 34038 -56
- Misses 5765 5894 +129
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/odbc/hooks/odbc.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb2RiYy9ob29rcy9vZGJjLnB5) | `92.22% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/api/client/local\_client.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2xvY2FsX2NsaWVudC5weQ==) | `92% <0%> (-8%)` | :arrow_down: |
| [airflow/api/client/api\_client.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2FwaV9jbGllbnQucHk=) | `63.15% <0%> (-1.55%)` | :arrow_down: |
| [airflow/lineage/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9saW5lYWdlL19faW5pdF9fLnB5) | `93.84% <0%> (ø)` | :arrow_up: |
| [airflow/api/client/json\_client.py](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2pzb25fY2xpZW50LnB5) | `0% <0%> (ø)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7224/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=footer). Last update [5b44c0f...933319f](https://codecov.io/gh/apache/airflow/pull/7224?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services