You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Ross Gardler (JIRA)" <ji...@apache.org> on 2005/07/11 11:02:09 UTC
[jira] Created: (FOR-573) Provide locationmap mounting capability
Provide locationmap mounting capability
---------------------------------------
Key: FOR-573
URL: http://issues.apache.org/jira/browse/FOR-573
Project: Forrest
Type: Improvement
Versions: 0.8-dev
Reporter: Ross Gardler
Fix For: 0.8-dev
Currently we cannot mount (or import) a locationmap from within another. We need this feature so that we can allow projects and/or plugins to override the default Forrest locationmap in the same way that we can override the default sitemaps.
This will then enable us to remve the workaround in <map:match pattern="locationmap.xml"> in main/webapp/sitemap.xmap in which we have the project sitemap completely overriding the forrest locationmap.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: locationmap mounting [was: Re: [jira] Commented: (FOR-573) Provide locationmap mounting capability
Posted by Tim Williams <wi...@gmail.com>.
On 8/29/05, Thorsten Scherler <th...@apache.org> wrote:
> On Mon, 2005-08-29 at 22:39 +0100, Ross Gardler wrote:
> > Thorsten Scherler wrote:
> >
> > > I wonder how the daisy plugin is working from a new seed.
> >
> > The daisy plugin does not provide a locationmap, it is up to the user to
> > do this in their project. This is Ok since the URL of the repository is
> > dependant on the project rather than the plugin.
> >
>
> Actually that is really bad for views and a showstopper to use the lm
> within views. Right now you have to do so much preparation that another
> step is just overkill. The activation of views already needs more time
> then building forrest.
>
> > I'd like to make it a config value and provide a plugin locationmap, but
> > that is for the future.
> >
>
> Please, no offense, but when you knew this, how could you suggest that I
> should refactor the view resolver code with the locationmap?
>
> If I check in my local version of views that means every project has to
> copy and paste the internal.view locationmap. Not really copyless.
>
> > > To understand it right, we would have to mount all locationsmap from
> > > plugins from the main lm in forrest, right. Did we thought about
> > > mounting them dynamically?
> >
> > Yes, what Tim is doing right now is a starting point that will allow
> > locationmaps to be mounted in the same way that plugin sitemaps are
> > mounted (i.e. configured at runtime).
> >
>
> Tim, I am more then willing to help. I do not want to touch the same
> classes that you may have changed on your drive. Please tell me how I
> can assist you.
>
> I will try tomorrow the mounting and report back. Maybe I can help
> enabling it the way you planed Tim.
Thanks, it was embarrassingly simple. This was clearly a case of me
over-thinking it which, unfortunately, happens more often than I care
to admit. I was worried about breaking backwards compatibility and
it took me some time to realize that the good old selector should just
be used on mounts as well. Anyway, it's done now so if we decide to
go the plugin-locationmap-mounting, the foundation is there.
--tim
Re: locationmap mounting [was: Re: [jira] Commented: (FOR-573)
Provide locationmap mounting capability
Posted by Thorsten Scherler <th...@apache.org>.
On Mon, 2005-08-29 at 20:47 -0400, Tim Williams wrote:
> On 8/29/05, Ross Gardler <rg...@apache.org> wrote:
> > Thorsten Scherler wrote:
> > > On Mon, 2005-08-29 at 22:39 +0100, Ross Gardler wrote:
> > >
> > >>Thorsten Scherler wrote:
> > >>
> > >>
> > >>>I wonder how the daisy plugin is working from a new seed.
> > >>
> > >>The daisy plugin does not provide a locationmap, it is up to the user to
> > >>do this in their project. This is Ok since the URL of the repository is
> > >>dependant on the project rather than the plugin.
> > >>
> > >
> > >
> > > Actually that is really bad for views and a showstopper to use the lm
> > > within views. Right now you have to do so much preparation that another
> > > step is just overkill. The activation of views already needs more time
> > > then building forrest.
> >
> > I have suggested, many times, that views should go into core in order to
> > remove the multiple dependencies between your plugins. It is precisely
> > because of this kind of complication that plugins are not supposed to
> > have dependencies as argued by Nicola and myself in, for example,
> > http://marc.theaimsgroup.com/?l=forrest-dev&m=111900690921015&w=2
>
> I assume Ross mis-typed here "between *your* plugins" and really meant
> "between view-related plugins" ;)
>
jeje, yes I have read it like you stated Tim. ;-)
> > >>I'd like to make it a config value and provide a plugin locationmap, but
> > >>that is for the future.
> > >>
> > >
> > >
> > > Please, no offense,
> >
> > [Hmmm... I'm bracing myself... I've written a reply and come back to
> > remove the "reaction" parts... ]
> >
Sorry, I do not understand this part.
> > > but when you knew this, how could you suggest that I
> > > should refactor the view resolver code with the locationmap?
> >
> > Please, do not get upset that someone does not have the foresight to
> > anticipate every potential hiccup in the development of the project. The
> > reality is that my not forseeing this particular hiccup is no worse than
> > you not foreseeing it - I don't know every detail of the project, just
> > as you do not.
Like I said, no offense, it is only what I said in the other mail.
Sometimes is better to be forced to write some code examples, because
you will properly see what will be the outcome and whether this is a
suitable solution.
No problem, the outcome of my refactoring is a more then suitable
solution, thanks to you and Tim. I just was a wee bit perplex when I
understood that I could not directly use it.
NO HARM DONE! ;-) ...
>
> Add me to the list of those without foresight -- I failed to think
> through that the selectors wouldn't work for views, leading you to
> have to implement locationmap actions.... wait a minute... now we have
> a more robust locationmap... shortsightedness ain't so bad sometimes;)
>
Exactly, no harm done just the opposite. I got into the locationmap and
now we have actions in the lm. Perfect outcome. ;-) The problem I am now
facing I had to face one day, start moving views to the core. ;-)
> > > If I check in my local version of views that means every project has to
> > > copy and paste the internal.view locationmap. Not really copyless.
> >
> > I don't understand what the problem is. Forrest:views are going in core
> > (eventually), therefore the locationmap settings for views should end up
> > in the core Forrest locationmap not some plugin locationmap. What am I
> > missing?
> >
Actually I did not tell the whole story. I did try to added the
locationmap matches into the core lm, but this got overridden by the
project lm. Well not anymore thx to Tim. ;-)
> > In the meantime we have a number of potential solutions:
> >
> > Start a branch and move internal-views into core. This will remove all
> > the dependencies between your plugins as we have always insisted must
> > happen.
I am -1 to open a branch for views. That will cause to much trouble to
afterwards merge it again. We will refactor heaps pipes in the meantime
in trunk and like said before they are the same like for views. We would
end up merging lots of file by hand because we would see "C ...".
As long we keep 2-3 pipes in the plugins we can move nearly everything
into the core without running the danger to hurt the core. The 2-3 are
mainly the *.html part of the plugins.
> >
> > If you don't want to move it to core yet then we can rely on users
> > copying the locationmap into the project since the plugin is still in
> > the whiteboard and so is not in a finished state.
> >
Hmm, I think I will move at least the view resolver part to the core
because it is nice code and will not have any influence of the rest of
forrest.
> > If this is too much for views to be enabled and you still insist on
> > working with the internal plugin model then I'd recomend that we enhance
> > the plugin loading code and, if necessary, the locationmap to mount a lm
> > provided by a plugin.
I do not insist on it. I will start moving parts of views into the core.
Anyway, +1 to enhance the plugin loading code to allow plugins to
provide their own lm.
>
> I wonder if there's not another option. It seems like your locations
> wouldn't collide with anything so would there be any harm in just
> putting them in the seed locationmap? If so, you could at least put
> them in there with comments wrapping them.
>
I once added view support to the seed when we were in the lm-branch.
When we left the branch people thought it is better to get rid of this
direct support of views. Now we have commented out this part of code.
I reckon I will create a new seed: seed-views. That target will provide
view support out-of the box (still we need to deploy the plugins local).
> > Tell us what you need, we will help you achieve it.
>
> +1
>
Cheers you already helped me.
salu2
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
Re: locationmap mounting [was: Re: [jira] Commented: (FOR-573) Provide
locationmap mounting capability
Posted by Ross Gardler <rg...@apache.org>.
Tim Williams wrote:
> I've taken an initial look at the plugin code and it seems that we
> could get this working quickly if it's desired. It looks like we just
> need to do roughly the following:
> 1) create a new target "configure-locationmap" in targets/plugins.xml
> 2) obviously make the call to it probably in configure plugin
> 3) create an pluginMountLmSnippet.xsl
> 4) add the following to forrest:locationmap
> <select>
> <mount src="{project:temp-dir}/locationmap.xml"/>
> </select>
> 5) cross fingers and test...
That is exactly what I had in mind, yes.
> Having written this, I'm still not convinced it's needed. The only
> use-case I can think of is the views and, since that's a temporary
> use-case, I'm not sure it's worth it.
That is also my opinion, although one never knows what other use cases
are around the corner.
Ross
Re: locationmap mounting [was: Re: [jira] Commented: (FOR-573) Provide locationmap mounting capability
Posted by Tim Williams <wi...@gmail.com>.
I've taken an initial look at the plugin code and it seems that we
could get this working quickly if it's desired. It looks like we just
need to do roughly the following:
1) create a new target "configure-locationmap" in targets/plugins.xml
2) obviously make the call to it probably in configure plugin
3) create an pluginMountLmSnippet.xsl
4) add the following to forrest:locationmap
<select>
<mount src="{project:temp-dir}/locationmap.xml"/>
</select>
5) cross fingers and test...
Having written this, I'm still not convinced it's needed. The only
use-case I can think of is the views and, since that's a temporary
use-case, I'm not sure it's worth it.
--tim
On 8/29/05, Tim Williams <wi...@gmail.com> wrote:
> On 8/29/05, Ross Gardler <rg...@apache.org> wrote:
> > Thorsten Scherler wrote:
> > > On Mon, 2005-08-29 at 22:39 +0100, Ross Gardler wrote:
> > >
> > >>Thorsten Scherler wrote:
> > >>
> > >>
> > >>>I wonder how the daisy plugin is working from a new seed.
> > >>
> > >>The daisy plugin does not provide a locationmap, it is up to the user to
> > >>do this in their project. This is Ok since the URL of the repository is
> > >>dependant on the project rather than the plugin.
> > >>
> > >
> > >
> > > Actually that is really bad for views and a showstopper to use the lm
> > > within views. Right now you have to do so much preparation that another
> > > step is just overkill. The activation of views already needs more time
> > > then building forrest.
> >
> > I have suggested, many times, that views should go into core in order to
> > remove the multiple dependencies between your plugins. It is precisely
> > because of this kind of complication that plugins are not supposed to
> > have dependencies as argued by Nicola and myself in, for example,
> > http://marc.theaimsgroup.com/?l=forrest-dev&m=111900690921015&w=2
>
> I assume Ross mis-typed here "between *your* plugins" and really meant
> "between view-related plugins" ;)
>
> > >>I'd like to make it a config value and provide a plugin locationmap, but
> > >>that is for the future.
> > >>
> > >
> > >
> > > Please, no offense,
> >
> > [Hmmm... I'm bracing myself... I've written a reply and come back to
> > remove the "reaction" parts... ]
> >
> > > but when you knew this, how could you suggest that I
> > > should refactor the view resolver code with the locationmap?
> >
> > Please, do not get upset that someone does not have the foresight to
> > anticipate every potential hiccup in the development of the project. The
> > reality is that my not forseeing this particular hiccup is no worse than
> > you not foreseeing it - I don't know every detail of the project, just
> > as you do not.
>
> Add me to the list of those without foresight -- I failed to think
> through that the selectors wouldn't work for views, leading you to
> have to implement locationmap actions.... wait a minute... now we have
> a more robust locationmap... shortsightedness ain't so bad sometimes;)
>
> > > If I check in my local version of views that means every project has to
> > > copy and paste the internal.view locationmap. Not really copyless.
> >
> > I don't understand what the problem is. Forrest:views are going in core
> > (eventually), therefore the locationmap settings for views should end up
> > in the core Forrest locationmap not some plugin locationmap. What am I
> > missing?
> >
> > In the meantime we have a number of potential solutions:
> >
> > Start a branch and move internal-views into core. This will remove all
> > the dependencies between your plugins as we have always insisted must
> > happen.
> >
> > If you don't want to move it to core yet then we can rely on users
> > copying the locationmap into the project since the plugin is still in
> > the whiteboard and so is not in a finished state.
> >
> > If this is too much for views to be enabled and you still insist on
> > working with the internal plugin model then I'd recomend that we enhance
> > the plugin loading code and, if necessary, the locationmap to mount a lm
> > provided by a plugin.
>
> I wonder if there's not another option. It seems like your locations
> wouldn't collide with anything so would there be any harm in just
> putting them in the seed locationmap? If so, you could at least put
> them in there with comments wrapping them.
>
> > Tell us what you need, we will help you achieve it.
>
> +1
>
> --tim
>
Re: locationmap mounting [was: Re: [jira] Commented: (FOR-573) Provide locationmap mounting capability
Posted by Tim Williams <wi...@gmail.com>.
On 8/29/05, Ross Gardler <rg...@apache.org> wrote:
> Thorsten Scherler wrote:
> > On Mon, 2005-08-29 at 22:39 +0100, Ross Gardler wrote:
> >
> >>Thorsten Scherler wrote:
> >>
> >>
> >>>I wonder how the daisy plugin is working from a new seed.
> >>
> >>The daisy plugin does not provide a locationmap, it is up to the user to
> >>do this in their project. This is Ok since the URL of the repository is
> >>dependant on the project rather than the plugin.
> >>
> >
> >
> > Actually that is really bad for views and a showstopper to use the lm
> > within views. Right now you have to do so much preparation that another
> > step is just overkill. The activation of views already needs more time
> > then building forrest.
>
> I have suggested, many times, that views should go into core in order to
> remove the multiple dependencies between your plugins. It is precisely
> because of this kind of complication that plugins are not supposed to
> have dependencies as argued by Nicola and myself in, for example,
> http://marc.theaimsgroup.com/?l=forrest-dev&m=111900690921015&w=2
I assume Ross mis-typed here "between *your* plugins" and really meant
"between view-related plugins" ;)
> >>I'd like to make it a config value and provide a plugin locationmap, but
> >>that is for the future.
> >>
> >
> >
> > Please, no offense,
>
> [Hmmm... I'm bracing myself... I've written a reply and come back to
> remove the "reaction" parts... ]
>
> > but when you knew this, how could you suggest that I
> > should refactor the view resolver code with the locationmap?
>
> Please, do not get upset that someone does not have the foresight to
> anticipate every potential hiccup in the development of the project. The
> reality is that my not forseeing this particular hiccup is no worse than
> you not foreseeing it - I don't know every detail of the project, just
> as you do not.
Add me to the list of those without foresight -- I failed to think
through that the selectors wouldn't work for views, leading you to
have to implement locationmap actions.... wait a minute... now we have
a more robust locationmap... shortsightedness ain't so bad sometimes;)
> > If I check in my local version of views that means every project has to
> > copy and paste the internal.view locationmap. Not really copyless.
>
> I don't understand what the problem is. Forrest:views are going in core
> (eventually), therefore the locationmap settings for views should end up
> in the core Forrest locationmap not some plugin locationmap. What am I
> missing?
>
> In the meantime we have a number of potential solutions:
>
> Start a branch and move internal-views into core. This will remove all
> the dependencies between your plugins as we have always insisted must
> happen.
>
> If you don't want to move it to core yet then we can rely on users
> copying the locationmap into the project since the plugin is still in
> the whiteboard and so is not in a finished state.
>
> If this is too much for views to be enabled and you still insist on
> working with the internal plugin model then I'd recomend that we enhance
> the plugin loading code and, if necessary, the locationmap to mount a lm
> provided by a plugin.
I wonder if there's not another option. It seems like your locations
wouldn't collide with anything so would there be any harm in just
putting them in the seed locationmap? If so, you could at least put
them in there with comments wrapping them.
> Tell us what you need, we will help you achieve it.
+1
--tim
Re: locationmap mounting [was: Re: [jira] Commented: (FOR-573) Provide
locationmap mounting capability
Posted by Ross Gardler <rg...@apache.org>.
Thorsten Scherler wrote:
> On Mon, 2005-08-29 at 22:39 +0100, Ross Gardler wrote:
>
>>Thorsten Scherler wrote:
>>
>>
>>>I wonder how the daisy plugin is working from a new seed.
>>
>>The daisy plugin does not provide a locationmap, it is up to the user to
>>do this in their project. This is Ok since the URL of the repository is
>>dependant on the project rather than the plugin.
>>
>
>
> Actually that is really bad for views and a showstopper to use the lm
> within views. Right now you have to do so much preparation that another
> step is just overkill. The activation of views already needs more time
> then building forrest.
I have suggested, many times, that views should go into core in order to
remove the multiple dependencies between your plugins. It is precisely
because of this kind of complication that plugins are not supposed to
have dependencies as argued by Nicola and myself in, for example,
http://marc.theaimsgroup.com/?l=forrest-dev&m=111900690921015&w=2
>>I'd like to make it a config value and provide a plugin locationmap, but
>>that is for the future.
>>
>
>
> Please, no offense,
[Hmmm... I'm bracing myself... I've written a reply and come back to
remove the "reaction" parts... ]
> but when you knew this, how could you suggest that I
> should refactor the view resolver code with the locationmap?
Please, do not get upset that someone does not have the foresight to
anticipate every potential hiccup in the development of the project. The
reality is that my not forseeing this particular hiccup is no worse than
you not foreseeing it - I don't know every detail of the project, just
as you do not.
> If I check in my local version of views that means every project has to
> copy and paste the internal.view locationmap. Not really copyless.
I don't understand what the problem is. Forrest:views are going in core
(eventually), therefore the locationmap settings for views should end up
in the core Forrest locationmap not some plugin locationmap. What am I
missing?
In the meantime we have a number of potential solutions:
Start a branch and move internal-views into core. This will remove all
the dependencies between your plugins as we have always insisted must
happen.
If you don't want to move it to core yet then we can rely on users
copying the locationmap into the project since the plugin is still in
the whiteboard and so is not in a finished state.
If this is too much for views to be enabled and you still insist on
working with the internal plugin model then I'd recomend that we enhance
the plugin loading code and, if necessary, the locationmap to mount a lm
provided by a plugin.
Tell us what you need, we will help you achieve it.
Ross
Re: locationmap mounting [was: Re: [jira] Commented:
(FOR-573) Provide locationmap mounting capability
Posted by Thorsten Scherler <th...@apache.org>.
On Mon, 2005-08-29 at 22:39 +0100, Ross Gardler wrote:
> Thorsten Scherler wrote:
>
> > I wonder how the daisy plugin is working from a new seed.
>
> The daisy plugin does not provide a locationmap, it is up to the user to
> do this in their project. This is Ok since the URL of the repository is
> dependant on the project rather than the plugin.
>
Actually that is really bad for views and a showstopper to use the lm
within views. Right now you have to do so much preparation that another
step is just overkill. The activation of views already needs more time
then building forrest.
> I'd like to make it a config value and provide a plugin locationmap, but
> that is for the future.
>
Please, no offense, but when you knew this, how could you suggest that I
should refactor the view resolver code with the locationmap?
If I check in my local version of views that means every project has to
copy and paste the internal.view locationmap. Not really copyless.
> > To understand it right, we would have to mount all locationsmap from
> > plugins from the main lm in forrest, right. Did we thought about
> > mounting them dynamically?
>
> Yes, what Tim is doing right now is a starting point that will allow
> locationmaps to be mounted in the same way that plugin sitemaps are
> mounted (i.e. configured at runtime).
>
Tim, I am more then willing to help. I do not want to touch the same
classes that you may have changed on your drive. Please tell me how I
can assist you.
I will try tomorrow the mounting and report back. Maybe I can help
enabling it the way you planed Tim.
salu2
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
Re: locationmap mounting [was: Re: [jira] Commented: (FOR-573) Provide
locationmap mounting capability
Posted by Ross Gardler <rg...@apache.org>.
Thorsten Scherler wrote:
> I wonder how the daisy plugin is working from a new seed.
The daisy plugin does not provide a locationmap, it is up to the user to
do this in their project. This is Ok since the URL of the repository is
dependant on the project rather than the plugin.
I'd like to make it a config value and provide a plugin locationmap, but
that is for the future.
> To understand it right, we would have to mount all locationsmap from
> plugins from the main lm in forrest, right. Did we thought about
> mounting them dynamically?
Yes, what Tim is doing right now is a starting point that will allow
locationmaps to be mounted in the same way that plugin sitemaps are
mounted (i.e. configured at runtime).
When the config changes come along I am hoping to be able to enable true
dynamic mounting, but again, that is for later. One step at a time.
Ross
Re: locationmap mounting [was: Re: [jira] Commented: (FOR-573) Provide locationmap mounting capability
Posted by Tim Williams <wi...@gmail.com>.
On 8/29/05, Thorsten Scherler <th...@apache.org> wrote:
> On Mon, 2005-08-29 at 15:39 -0400, Tim Williams wrote:
> > On 8/29/05, Thorsten Scherler (JIRA) <ji...@apache.org> wrote:
> > > [ http://issues.apache.org/jira/browse/FOR-573?page=comments#action_12320465 ]
> > >
> > > Thorsten Scherler commented on FOR-573:
> > > ---------------------------------------
> > >
> > > I tried to rewrite the internal.view plugin with the locationmap, but that was not working like I expected. I only have been able to see the lm rewritting when I did forrest run in the root of the plugin. I reckon it is because of this issue.
> > >
> > > Is there a an example of the mount in the lm?
> >
> > I'm replying onlist instead of through JIRA to keep JIRA clean of
> > free-flowing discussion -- assuming that's desired.
> >
> > I've pasted a mounting example below. Note that because of another
> > issue, the lm being mounted *must* exist. I'm hoping to fix that this
> > evening though. Then the syntax will change to become:
> > <select>
> > <mount src="somelocationmap.xml"/>
> > </select>
> >
> > That said, I'm not sure if that's causing your issue or not. Are you
> > saying you the locationmap isn't working when you try it on a
> > seed-sample site? I actually would have expected it to be the other
> > way around since plugin-locationmaps have yet to be tested at all and
> > aren't even being mounted via the workaround AFAIK.
>
> Your suspected right.
>
> I added
> plugins/org.apache.forrest.plugin.internal.view/src/documentation/content/locationmap.xml and changed the internal.xmap to use {lm:test}.
>
> When I now change to org.apache.forrest.plugin.internal.view and do
> forrest run then everything works fine like I expected.
>
> Now I change my test project and the locationmap {lm:test} do not get
> matched anymore within views.
>
> I wonder how the daisy plugin is working from a new seed.
>
> To understand it right, we would have to mount all locationsmap from
> plugins from the main lm in forrest, right. Did we thought about
> mounting them dynamically?
There hasn't been a use-case for plugin locationmaps yet. It
shouldn't be too difficult to do though. I think the model is already
there with the *.xmap's for plugins, however they are added to a
project, the same approach would be taken along with an exists-based
mounting in forrest:locationmap.xml.
Having said that, I think Ross's reply is the preferred approach --
let's go ahead with views' final destination and get it in the core
via a branch.
Either way, I'm here to help you get this working however you want to proceed.
--tim
Re: locationmap mounting [was: Re: [jira] Commented: (FOR-573)
Provide locationmap mounting capability
Posted by Thorsten Scherler <th...@apache.org>.
On Mon, 2005-08-29 at 15:39 -0400, Tim Williams wrote:
> On 8/29/05, Thorsten Scherler (JIRA) <ji...@apache.org> wrote:
> > [ http://issues.apache.org/jira/browse/FOR-573?page=comments#action_12320465 ]
> >
> > Thorsten Scherler commented on FOR-573:
> > ---------------------------------------
> >
> > I tried to rewrite the internal.view plugin with the locationmap, but that was not working like I expected. I only have been able to see the lm rewritting when I did forrest run in the root of the plugin. I reckon it is because of this issue.
> >
> > Is there a an example of the mount in the lm?
>
> I'm replying onlist instead of through JIRA to keep JIRA clean of
> free-flowing discussion -- assuming that's desired.
>
> I've pasted a mounting example below. Note that because of another
> issue, the lm being mounted *must* exist. I'm hoping to fix that this
> evening though. Then the syntax will change to become:
> <select>
> <mount src="somelocationmap.xml"/>
> </select>
>
> That said, I'm not sure if that's causing your issue or not. Are you
> saying you the locationmap isn't working when you try it on a
> seed-sample site? I actually would have expected it to be the other
> way around since plugin-locationmaps have yet to be tested at all and
> aren't even being mounted via the workaround AFAIK.
Your suspected right.
I added
plugins/org.apache.forrest.plugin.internal.view/src/documentation/content/locationmap.xml and changed the internal.xmap to use {lm:test}.
When I now change to org.apache.forrest.plugin.internal.view and do
forrest run then everything works fine like I expected.
Now I change my test project and the locationmap {lm:test} do not get
matched anymore within views.
I wonder how the daisy plugin is working from a new seed.
To understand it right, we would have to mount all locationsmap from
plugins from the main lm in forrest, right. Did we thought about
mounting them dynamically?
Thx.
salu2
> --tim
>
>
> <locationmap xmlns="http://apache.org/forrest/locationmap/1.0">
>
> <components>
> <matchers default="lm">
> <matcher
> name="lm"
> src="org.apache.forrest.locationmap.WildcardLocationMapHintMatcher"/>
> </matchers>
> </components>
>
> <mount src="{project:content}locationmap2.xml"/>
>
> <locator>
> <match pattern="rewriteDemo/**">
> <location src="http://www.burrokeet.org/{1}.xml" />
> </match>
> <match pattern="remoteDemo/**.xml">
> <location
> src="http://svn.apache.org/repos/asf/forrest/trunk/site-author/content/xdocs/{1}.xml"
> />
> </match>
> </locator>
> </locationmap>
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
locationmap mounting [was: Re: [jira] Commented: (FOR-573) Provide locationmap mounting capability
Posted by Tim Williams <wi...@gmail.com>.
On 8/29/05, Thorsten Scherler (JIRA) <ji...@apache.org> wrote:
> [ http://issues.apache.org/jira/browse/FOR-573?page=comments#action_12320465 ]
>
> Thorsten Scherler commented on FOR-573:
> ---------------------------------------
>
> I tried to rewrite the internal.view plugin with the locationmap, but that was not working like I expected. I only have been able to see the lm rewritting when I did forrest run in the root of the plugin. I reckon it is because of this issue.
>
> Is there a an example of the mount in the lm?
I'm replying onlist instead of through JIRA to keep JIRA clean of
free-flowing discussion -- assuming that's desired.
I've pasted a mounting example below. Note that because of another
issue, the lm being mounted *must* exist. I'm hoping to fix that this
evening though. Then the syntax will change to become:
<select>
<mount src="somelocationmap.xml"/>
</select>
That said, I'm not sure if that's causing your issue or not. Are you
saying you the locationmap isn't working when you try it on a
seed-sample site? I actually would have expected it to be the other
way around since plugin-locationmaps have yet to be tested at all and
aren't even being mounted via the workaround AFAIK.
--tim
<locationmap xmlns="http://apache.org/forrest/locationmap/1.0">
<components>
<matchers default="lm">
<matcher
name="lm"
src="org.apache.forrest.locationmap.WildcardLocationMapHintMatcher"/>
</matchers>
</components>
<mount src="{project:content}locationmap2.xml"/>
<locator>
<match pattern="rewriteDemo/**">
<location src="http://www.burrokeet.org/{1}.xml" />
</match>
<match pattern="remoteDemo/**.xml">
<location
src="http://svn.apache.org/repos/asf/forrest/trunk/site-author/content/xdocs/{1}.xml"
/>
</match>
</locator>
</locationmap>
[jira] Updated: (FOR-573) Provide locationmap mounting capability
Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-573?page=all ]
Ross Gardler updated FOR-573:
-----------------------------
Component: Locationmap
> Provide locationmap mounting capability
> ---------------------------------------
>
> Key: FOR-573
> URL: http://issues.apache.org/jira/browse/FOR-573
> Project: Forrest
> Type: Improvement
> Components: Locationmap
> Versions: 0.8-dev
> Reporter: Ross Gardler
> Fix For: 0.8-dev
>
> Currently we cannot mount (or import) a locationmap from within another. We need this feature so that we can allow projects and/or plugins to override the default Forrest locationmap in the same way that we can override the default sitemaps.
> This will then enable us to remve the workaround in <map:match pattern="locationmap.xml"> in main/webapp/sitemap.xmap in which we have the project sitemap completely overriding the forrest locationmap.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-573) Provide locationmap mounting capability
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-573?page=comments#action_12320465 ]
Thorsten Scherler commented on FOR-573:
---------------------------------------
I tried to rewrite the internal.view plugin with the locationmap, but that was not working like I expected. I only have been able to see the lm rewritting when I did forrest run in the root of the plugin. I reckon it is because of this issue.
Is there a an example of the mount in the lm?
> Provide locationmap mounting capability
> ---------------------------------------
>
> Key: FOR-573
> URL: http://issues.apache.org/jira/browse/FOR-573
> Project: Forrest
> Type: Improvement
> Components: Locationmap
> Versions: 0.8-dev
> Reporter: Ross Gardler
> Assignee: Tim Williams
> Fix For: 0.8-dev
>
> Currently we cannot mount (or import) a locationmap from within another. We need this feature so that we can allow projects and/or plugins to override the default Forrest locationmap in the same way that we can override the default sitemaps.
> This will then enable us to remve the workaround in <map:match pattern="locationmap.xml"> in main/webapp/sitemap.xmap in which we have the project sitemap completely overriding the forrest locationmap.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Resolved: (FOR-573) Provide locationmap mounting
capability
Posted by Thorsten Scherler <th...@apache.org>.
On Tue, 2005-08-30 at 04:49 +0200, Tim Williams (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/FOR-573?page=all ]
>
> Tim Williams resolved FOR-573:
> ------------------------------
>
> Resolution: Fixed
:)
Cheers.
I will test tonight.
salu2
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
[jira] Resolved: (FOR-573) Provide locationmap mounting capability
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-573?page=all ]
Tim Williams resolved FOR-573:
------------------------------
Resolution: Fixed
With the addition of selector based mounting, this one is complete.
> Provide locationmap mounting capability
> ---------------------------------------
>
> Key: FOR-573
> URL: http://issues.apache.org/jira/browse/FOR-573
> Project: Forrest
> Type: Improvement
> Components: Locationmap
> Versions: 0.8-dev
> Reporter: Ross Gardler
> Assignee: Tim Williams
> Fix For: 0.8-dev
>
> Currently we cannot mount (or import) a locationmap from within another. We need this feature so that we can allow projects and/or plugins to override the default Forrest locationmap in the same way that we can override the default sitemaps.
> This will then enable us to remve the workaround in <map:match pattern="locationmap.xml"> in main/webapp/sitemap.xmap in which we have the project sitemap completely overriding the forrest locationmap.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-573) Provide locationmap mounting capability
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-573?page=comments#action_12315569 ]
Tim Williams commented on FOR-573:
----------------------------------
This should be in the "Locationmap" component in JIRA
> Provide locationmap mounting capability
> ---------------------------------------
>
> Key: FOR-573
> URL: http://issues.apache.org/jira/browse/FOR-573
> Project: Forrest
> Type: Improvement
> Versions: 0.8-dev
> Reporter: Ross Gardler
> Fix For: 0.8-dev
>
> Currently we cannot mount (or import) a locationmap from within another. We need this feature so that we can allow projects and/or plugins to override the default Forrest locationmap in the same way that we can override the default sitemaps.
> This will then enable us to remve the workaround in <map:match pattern="locationmap.xml"> in main/webapp/sitemap.xmap in which we have the project sitemap completely overriding the forrest locationmap.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (FOR-573) Provide locationmap mounting capability
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-573?page=all ]
Tim Williams reassigned FOR-573:
--------------------------------
Assign To: Tim Williams
> Provide locationmap mounting capability
> ---------------------------------------
>
> Key: FOR-573
> URL: http://issues.apache.org/jira/browse/FOR-573
> Project: Forrest
> Type: Improvement
> Components: Locationmap
> Versions: 0.8-dev
> Reporter: Ross Gardler
> Assignee: Tim Williams
> Fix For: 0.8-dev
>
> Currently we cannot mount (or import) a locationmap from within another. We need this feature so that we can allow projects and/or plugins to override the default Forrest locationmap in the same way that we can override the default sitemaps.
> This will then enable us to remve the workaround in <map:match pattern="locationmap.xml"> in main/webapp/sitemap.xmap in which we have the project sitemap completely overriding the forrest locationmap.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-573) Provide locationmap mounting capability
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-573?page=comments#action_12315482 ]
Tim Williams commented on FOR-573:
----------------------------------
The following are relevant background material for this issue.
This discussion on forrest-dev:
http://marc.theaimsgroup.com/?t=112085278700001&r=1&w=2
and this discussion on cocoon-dev:
http://marc.theaimsgroup.com/?t=112107463200002&r=1&w=2
> Provide locationmap mounting capability
> ---------------------------------------
>
> Key: FOR-573
> URL: http://issues.apache.org/jira/browse/FOR-573
> Project: Forrest
> Type: Improvement
> Versions: 0.8-dev
> Reporter: Ross Gardler
> Fix For: 0.8-dev
>
> Currently we cannot mount (or import) a locationmap from within another. We need this feature so that we can allow projects and/or plugins to override the default Forrest locationmap in the same way that we can override the default sitemaps.
> This will then enable us to remve the workaround in <map:match pattern="locationmap.xml"> in main/webapp/sitemap.xmap in which we have the project sitemap completely overriding the forrest locationmap.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira