You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/08/25 07:33:25 UTC

[GitHub] [incubator-shenyu] yu199195 opened a new pull request #1974: [type: refactor] refactor some code

yu199195 opened a new pull request #1974:
URL: https://github.com/apache/incubator-shenyu/pull/1974


   // Describe your PR here; eg. Fixes #issueNo
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor/).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1974: [type: refactor] refactor some code

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1974:
URL: https://github.com/apache/incubator-shenyu/pull/1974#issuecomment-905264887


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1974](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dad1eca) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/df27f61b6c96f6e24e2054422060fefed612258c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df27f61) will **decrease** coverage by `0.09%`.
   > The diff coverage is `89.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1974      +/-   ##
   ============================================
   - Coverage     62.50%   62.41%   -0.10%     
   + Complexity     4003     4002       -1     
   ============================================
     Files           593      593              
     Lines         17305    17295      -10     
     Branches       1662     1662              
   ============================================
   - Hits          10817    10795      -22     
   - Misses         5623     5630       +7     
   - Partials        865      870       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...nyu/plugin/cryptor/decorator/RequestDecorator.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9kZWNvcmF0b3IvUmVxdWVzdERlY29yYXRvci5qYXZh) | `44.44% <ø> (ø)` | |
   | [...yu/plugin/cryptor/decorator/ResponseDecorator.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9kZWNvcmF0b3IvUmVzcG9uc2VEZWNvcmF0b3IuamF2YQ==) | `75.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/cryptor/strategy/RsaStrategy.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9zdHJhdGVneS9Sc2FTdHJhdGVneS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...g/apache/shenyu/plugin/cryptor/utils/HttpUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci91dGlscy9IdHRwVXRpbC5qYXZh) | `26.66% <ø> (ø)` | |
   | [...g/apache/shenyu/plugin/cryptor/utils/JsonUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci91dGlscy9Kc29uVXRpbC5qYXZh) | `45.83% <ø> (ø)` | |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <0.00%> (ø)` | |
   | [...lugin/cryptor/strategy/CryptorStrategyFactory.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9zdHJhdGVneS9DcnlwdG9yU3RyYXRlZ3lGYWN0b3J5LmphdmE=) | `36.36% <36.36%> (ø)` | |
   | [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...g/apache/shenyu/admin/transfer/PluginTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvUGx1Z2luVHJhbnNmZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...ext/path/handler/ContextPathPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNvbnRleHQtcGF0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9jb250ZXh0L3BhdGgvaGFuZGxlci9Db250ZXh0UGF0aFBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `10.00% <100.00%> (ø)` | |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df27f61...dad1eca](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] dengliming merged pull request #1974: [type: refactor] refactor some code

Posted by GitBox <gi...@apache.org>.

dengliming merged pull request #1974:
URL: https://github.com/apache/incubator-shenyu/pull/1974


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1974: [type: refactor] refactor some code

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1974:
URL: https://github.com/apache/incubator-shenyu/pull/1974#issuecomment-905264887


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1974](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dad1eca) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/df27f61b6c96f6e24e2054422060fefed612258c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df27f61) will **decrease** coverage by `0.04%`.
   > The diff coverage is `89.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1974      +/-   ##
   ============================================
   - Coverage     62.50%   62.46%   -0.05%     
     Complexity     4003     4003              
   ============================================
     Files           593      593              
     Lines         17305    17295      -10     
     Branches       1662     1662              
   ============================================
   - Hits          10817    10803      -14     
   - Misses         5623     5626       +3     
   - Partials        865      866       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...nyu/plugin/cryptor/decorator/RequestDecorator.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9kZWNvcmF0b3IvUmVxdWVzdERlY29yYXRvci5qYXZh) | `44.44% <ø> (ø)` | |
   | [...yu/plugin/cryptor/decorator/ResponseDecorator.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9kZWNvcmF0b3IvUmVzcG9uc2VEZWNvcmF0b3IuamF2YQ==) | `75.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/cryptor/strategy/RsaStrategy.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9zdHJhdGVneS9Sc2FTdHJhdGVneS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...g/apache/shenyu/plugin/cryptor/utils/HttpUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci91dGlscy9IdHRwVXRpbC5qYXZh) | `26.66% <ø> (ø)` | |
   | [...g/apache/shenyu/plugin/cryptor/utils/JsonUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci91dGlscy9Kc29uVXRpbC5qYXZh) | `45.83% <ø> (ø)` | |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <0.00%> (ø)` | |
   | [...lugin/cryptor/strategy/CryptorStrategyFactory.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9zdHJhdGVneS9DcnlwdG9yU3RyYXRlZ3lGYWN0b3J5LmphdmE=) | `36.36% <36.36%> (ø)` | |
   | [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...g/apache/shenyu/admin/transfer/PluginTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvUGx1Z2luVHJhbnNmZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...ext/path/handler/ContextPathPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNvbnRleHQtcGF0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9jb250ZXh0L3BhdGgvaGFuZGxlci9Db250ZXh0UGF0aFBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `10.00% <100.00%> (ø)` | |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df27f61...dad1eca](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #1974: [type: refactor] refactor some code

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #1974:
URL: https://github.com/apache/incubator-shenyu/pull/1974#issuecomment-905264887


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1974](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dad1eca) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/df27f61b6c96f6e24e2054422060fefed612258c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df27f61) will **decrease** coverage by `0.35%`.
   > The diff coverage is `89.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1974      +/-   ##
   ============================================
   - Coverage     62.50%   62.15%   -0.36%     
   + Complexity     4003     3991      -12     
   ============================================
     Files           593      593              
     Lines         17305    17295      -10     
     Branches       1662     1662              
   ============================================
   - Hits          10817    10750      -67     
   - Misses         5623     5679      +56     
   - Partials        865      866       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...nyu/plugin/cryptor/decorator/RequestDecorator.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9kZWNvcmF0b3IvUmVxdWVzdERlY29yYXRvci5qYXZh) | `44.44% <ø> (ø)` | |
   | [...yu/plugin/cryptor/decorator/ResponseDecorator.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9kZWNvcmF0b3IvUmVzcG9uc2VEZWNvcmF0b3IuamF2YQ==) | `75.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/cryptor/strategy/RsaStrategy.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9zdHJhdGVneS9Sc2FTdHJhdGVneS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...g/apache/shenyu/plugin/cryptor/utils/HttpUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci91dGlscy9IdHRwVXRpbC5qYXZh) | `26.66% <ø> (ø)` | |
   | [...g/apache/shenyu/plugin/cryptor/utils/JsonUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci91dGlscy9Kc29uVXRpbC5qYXZh) | `45.83% <ø> (ø)` | |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <0.00%> (ø)` | |
   | [...lugin/cryptor/strategy/CryptorStrategyFactory.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9zdHJhdGVneS9DcnlwdG9yU3RyYXRlZ3lGYWN0b3J5LmphdmE=) | `36.36% <36.36%> (ø)` | |
   | [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...g/apache/shenyu/admin/transfer/PluginTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvUGx1Z2luVHJhbnNmZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...ext/path/handler/ContextPathPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNvbnRleHQtcGF0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9jb250ZXh0L3BhdGgvaGFuZGxlci9Db250ZXh0UGF0aFBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `10.00% <100.00%> (ø)` | |
   | ... and [12 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df27f61...dad1eca](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1974: [type: refactor] refactor some code

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1974:
URL: https://github.com/apache/incubator-shenyu/pull/1974#issuecomment-905264887


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1974](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dad1eca) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/df27f61b6c96f6e24e2054422060fefed612258c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df27f61) will **increase** coverage by `0.00%`.
   > The diff coverage is `89.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1974   +/-   ##
   =========================================
     Coverage     62.50%   62.50%           
   - Complexity     4003     4005    +2     
   =========================================
     Files           593      593           
     Lines         17305    17295   -10     
     Branches       1662     1662           
   =========================================
   - Hits          10817    10811    -6     
   + Misses         5623     5620    -3     
   + Partials        865      864    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...nyu/plugin/cryptor/decorator/RequestDecorator.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9kZWNvcmF0b3IvUmVxdWVzdERlY29yYXRvci5qYXZh) | `44.44% <ø> (ø)` | |
   | [...yu/plugin/cryptor/decorator/ResponseDecorator.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9kZWNvcmF0b3IvUmVzcG9uc2VEZWNvcmF0b3IuamF2YQ==) | `75.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/cryptor/strategy/RsaStrategy.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9zdHJhdGVneS9Sc2FTdHJhdGVneS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...g/apache/shenyu/plugin/cryptor/utils/HttpUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci91dGlscy9IdHRwVXRpbC5qYXZh) | `26.66% <ø> (ø)` | |
   | [...g/apache/shenyu/plugin/cryptor/utils/JsonUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci91dGlscy9Kc29uVXRpbC5qYXZh) | `45.83% <ø> (ø)` | |
   | [...u/plugin/modify/response/ModifyResponsePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvTW9kaWZ5UmVzcG9uc2VQbHVnaW4uamF2YQ==) | `18.30% <0.00%> (ø)` | |
   | [...lugin/cryptor/strategy/CryptorStrategyFactory.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNyeXB0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vY3J5cHRvci9zdHJhdGVneS9DcnlwdG9yU3RyYXRlZ3lGYWN0b3J5LmphdmE=) | `36.36% <36.36%> (ø)` | |
   | [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...g/apache/shenyu/admin/transfer/PluginTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvUGx1Z2luVHJhbnNmZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...ext/path/handler/ContextPathPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNvbnRleHQtcGF0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9jb250ZXh0L3BhdGgvaGFuZGxlci9Db250ZXh0UGF0aFBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `10.00% <100.00%> (ø)` | |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1974/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df27f61...dad1eca](https://codecov.io/gh/apache/incubator-shenyu/pull/1974?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org