You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vchiapaikeo (via GitHub)" <gi...@apache.org> on 2023/02/07 21:03:19 UTC
[GitHub] [airflow] vchiapaikeo opened a new pull request, #29410: Edgemodifier refactoring w/ labels in TaskGroup edge case
vchiapaikeo opened a new pull request, #29410:
URL: https://github.com/apache/airflow/pull/29410
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vchiapaikeo commented on pull request #29410: Edgemodifier refactoring w/ labels in TaskGroup edge case
Posted by "vchiapaikeo (via GitHub)" <gi...@apache.org>.
vchiapaikeo commented on PR #29410:
URL: https://github.com/apache/airflow/pull/29410#issuecomment-1434840245
Ah good catch @josh-fell - added this and updated the screenshots in the description.
<img width="1399" alt="image" src="https://user-images.githubusercontent.com/9200263/219688844-1c0f1f24-cc55-402f-8436-2774ed169591.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #29410: Edgemodifier refactoring w/ labels in TaskGroup edge case
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #29410:
URL: https://github.com/apache/airflow/pull/29410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vchiapaikeo commented on pull request #29410: Edgemodifier refactoring w/ labels in TaskGroup edge case
Posted by "vchiapaikeo (via GitHub)" <gi...@apache.org>.
vchiapaikeo commented on PR #29410:
URL: https://github.com/apache/airflow/pull/29410#issuecomment-1427020381
Sure @pierrejeambrun . I've added this test case and updated the table above with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vchiapaikeo commented on pull request #29410: Edgemodifier refactoring w/ labels in TaskGroup edge case
Posted by "vchiapaikeo (via GitHub)" <gi...@apache.org>.
vchiapaikeo commented on PR #29410:
URL: https://github.com/apache/airflow/pull/29410#issuecomment-1421659593
@pierrejeambrun , Elad mentioned I could reach out to you for some feedback. I'm hoping to refactor my logic in `_convert_streams_to_task_groups`. If you have any ideas, please let me know. Also, if you'd like me to add any more tests or run any special test cases, lmk as well! I've run all the tests dags from the previous PR and a couple of my own as well and I can add them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #29410: Edgemodifier refactoring w/ labels in TaskGroup edge case
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #29410:
URL: https://github.com/apache/airflow/pull/29410#issuecomment-1435675406
> @pierrejeambrun any further concerns?
LGTM !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org