[GitHub] [incubator-ratis] maobaolong commented on pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required

[GitBox <gi...@apache.org>]

maobaolong commented on pull request #49:
URL: https://github.com/apache/incubator-ratis/pull/49#issuecomment-647465824


   @jandrunas Thank you very much for your review. I've done test by execute MetadataServer without any argument.
   
   With this PR.
   
   Exception in thread "main" com.beust.jcommander.ParameterException: The following option is required: [-q | --metaQuorum]
   	at com.beust.jcommander.JCommander.validateOptions(JCommander.java:381)
   	at com.beust.jcommander.JCommander.parse(JCommander.java:341)
   	at com.beust.jcommander.JCommander.parse(JCommander.java:319)
   	at org.apache.ratis.logservice.server.MetadataServer.main(MetadataServer.java:121)
   
   WIthout this PR.
   
   Exception in thread "main" java.lang.NullPointerException
   	at org.apache.ratis.logservice.util.LogServiceUtils.getPeersFromQuorum(LogServiceUtils.java:43)
   	at org.apache.ratis.logservice.server.MetadataServer.start(MetadataServer.java:92)
   	at org.apache.ratis.logservice.server.MetadataServer.main(MetadataServer.java:127)
   	Suppressed: java.lang.NullPointerException
   		at org.apache.ratis.logservice.server.MetadataServer.close(MetadataServer.java:145)
   		at org.apache.ratis.logservice.server.MetadataServer.main(MetadataServer.java:136)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org