You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by Benjamin Marwell <bm...@gmail.com> on 2020/01/21 09:02:14 UTC
[SHIRO-481] guava-based cache -- close?
Hi everyone,
In this issue, someone requested a guava-based cache.
https://issues.apache.org/jira/browse/SHIRO-481
He does not need it anymore, but a patch is attached.
If you like I can create a PR, but I would rather close it. It is just
another dependency which does not add much value, especially if no one
requested this feature.
Therefore I would suggest to close it.
Ben
Re: [SHIRO-481] guava-based cache -- close?
Posted by Les Hazlewood <lh...@apache.org>.
+1 to dropping it.
On Tue, Jan 21, 2020 at 1:36 PM Brian Demers <br...@gmail.com> wrote:
> +1 for dropping it.
> I think if we wanted a guava cache impl, someone could create one on GitHub
> (or similar) and if it gained some interest we could pull it into Shiro.
> (Just trying to keep from spreading us too thin)
>
> On Tue, Jan 21, 2020 at 4:02 AM Benjamin Marwell <bm...@gmail.com>
> wrote:
>
> > Hi everyone,
> >
> > In this issue, someone requested a guava-based cache.
> > https://issues.apache.org/jira/browse/SHIRO-481
> >
> > He does not need it anymore, but a patch is attached.
> >
> > If you like I can create a PR, but I would rather close it. It is just
> > another dependency which does not add much value, especially if no one
> > requested this feature.
> >
> > Therefore I would suggest to close it.
> >
> > Ben
> >
>
Re: [SHIRO-481] guava-based cache -- close?
Posted by Brian Demers <br...@gmail.com>.
+1 for dropping it.
I think if we wanted a guava cache impl, someone could create one on GitHub
(or similar) and if it gained some interest we could pull it into Shiro.
(Just trying to keep from spreading us too thin)
On Tue, Jan 21, 2020 at 4:02 AM Benjamin Marwell <bm...@gmail.com> wrote:
> Hi everyone,
>
> In this issue, someone requested a guava-based cache.
> https://issues.apache.org/jira/browse/SHIRO-481
>
> He does not need it anymore, but a patch is attached.
>
> If you like I can create a PR, but I would rather close it. It is just
> another dependency which does not add much value, especially if no one
> requested this feature.
>
> Therefore I would suggest to close it.
>
> Ben
>