You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/12/05 22:20:34 UTC

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function 

John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8768


Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................

IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_datetime_functions.xml
3 files changed, 98 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8768/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, sandeep akinapelli, Alex Behm, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8768

to look at the new patch set (#2).

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................

IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_datetime_functions.xml
3 files changed, 96 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8768/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 5
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 16:23:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8768/3/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/8768/3/docs/topics/impala_datetime_functions.xml@463
PS3, Line 463: select now(), date_trunc('microseconds', now());
             : +-------------------------------+-----------------------------------+
             : | now()                         | date_trunc('second', now())       |
The query and 2nd column heading do not match



-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 22:31:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, sandeep akinapelli, Alex Behm, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8768

to look at the new patch set (#4).

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................

IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_datetime_functions.xml
3 files changed, 104 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8768/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 2:

Patch set 2 has 'nanoseconds' and 'quarter' removed.


-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Dec 2017 22:08:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 5
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 18:41:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 3:

(1 comment)

Serves me right for editing the output. (Had to fiddle with the query to get the exact same timestamp as before.)

http://gerrit.cloudera.org:8080/#/c/8768/3/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/8768/3/docs/topics/impala_datetime_functions.xml@463
PS3, Line 463: select now(), date_trunc('microseconds', now());
             : +-------------------------------+-----------------------------------+
             : | now()                         | date_trunc('second', now())       |
> The query and 2nd column heading do not match
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 23:20:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, sandeep akinapelli, Alex Behm, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8768

to look at the new patch set (#5).

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................

IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_datetime_functions.xml
3 files changed, 104 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8768/5
-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 5
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 5:

Tagging in Tim who reviewed the code. Some other committers not available to +2.


-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 5
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 04:47:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@400
PS2, Line 400: Strips off fields from a <codeph>TIMESTAMP</codeph> value
Can we use "truncates" not "strips off"?
eg. truncates to the specified precision


http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@455
PS2, Line 455: select now(), date_trunc('microseconds', now());
             : +-------------------------------+-----------------------------------+
             : | now()                         | date_trunc('microseconds', now()) |
             : +-------------------------------+-----------------------------------+
             : | 2017-12-05 13:58:04.565403000 | 2017-12-05 13:58:04.565403000     |
             : +-------------------------------+-----------------------------------+
now() never returns any nanosecond values so probably not a great example



-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 04:08:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@403
PS4, Line 403: values
> TIMESTAMP value or values?
'values' is grammatically correct here.


http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@422
PS4, Line 422: TS
> caps on TS and small TS mentioned earlier??
Sure. I follow a consistent pattern of capitalization for discussions in a pure SQL context - identifiers are lowercase in a statement like 'CREATE TABLE foo', but if I'm referring to the identifier itself I'll capitalize it, as in 'the table named FOO'. But in the discussions of built-in functions I use lowercase more frequently, more of a C-like style.


http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@430
PS4, Line 430: one secon
> what do you think about "one second" vs "second"
Grammatically there would need to be one other word there, either "a second" or "one second". Let's leave it as-is.



-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jan 2018 20:04:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................

IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Reviewed-on: http://gerrit.cloudera.org:8080/8768
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_datetime_functions.xml
3 files changed, 104 insertions(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 6
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 1:

See my note in https://issues.apache.org/jira/browse/IMPALA-5317. I couldn't get date_trunc() to recognize 'nanoseconds' or 'quarter' as unit arguments. I left them in the doc for the moment on the assumption that that's a code bug.


-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 22:23:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 4: Code-Review+1

LGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 23:41:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "sandeep akinapelli (Code Review)" <ge...@cloudera.org>.
sandeep akinapelli has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@403
PS4, Line 403: values
TIMESTAMP value or values?


http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@422
PS4, Line 422: TS
caps on TS and small TS mentioned earlier??


http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@430
PS4, Line 430: one secon
what do you think about "one second" vs "second"



-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Dec 2017 06:46:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@406
PS2, Line 406: 						
> Tabs! Don't know how those got in there.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 19:46:32 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 1:

Tagging in Alex for ability to +2 after Sandeep and Greg have taken a look.


-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 22:25:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@400
PS2, Line 400: Strips off fields from a <codeph>TIMESTAMP</codeph> value
> Can we use "truncates" not "strips off"?
Done


http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@406
PS2, Line 406: 						
Tabs! Don't know how those got in there.


http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@455
PS2, Line 455: select now(), date_trunc('microseconds', now());
             : +-------------------------------+-----------------------------------+
             : | now()                         | date_trunc('microseconds', now()) |
             : +-------------------------------+-----------------------------------+
             : | 2017-12-05 13:58:04.565403000 | 2017-12-05 13:58:04.565403000     |
             : +-------------------------------+-----------------------------------+
> now() never returns any nanosecond values so probably not a great example
Wow, even after I added the Note: above, I was fooled by the singular/plural business. I.e. thinking that 'microseconds' must set microseconds to zero rather setting everything _below_ a microsecond to zero. I'll add a little wording earlier on to reinforce where the precision boundary is.



-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 19:46:18 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, sandeep akinapelli, Alex Behm, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8768

to look at the new patch set (#3).

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................

IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_datetime_functions.xml
3 files changed, 104 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8768/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/181/


-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 5
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 18:30:51 +0000
Gerrit-HasComments: No