You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org> on 2026/06/13 06:46:44 UTC
[PR] [python] Ban blob column updates in update-by-row-id [paimon]
XiaoHongbo-Hope opened a new pull request, #8227:
URL: https://github.com/apache/paimon/pull/8227
### Purpose
### Tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Ban blob column updates in update-by-row-id [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #8227:
URL: https://github.com/apache/paimon/pull/8227#issuecomment-4698780063
I think you can fix it directly. The master branch will definitely have a lot of developing features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Ban blob column updates in update-by-row-id [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed pull request #8227: [python] Ban blob column updates in update-by-row-id
URL: https://github.com/apache/paimon/pull/8227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Ban blob column updates in update-by-row-id [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #8227:
URL: https://github.com/apache/paimon/pull/8227#discussion_r3407962221
##########
paimon-python/pypaimon/tests/blob_table_test.py:
##########
@@ -1059,10 +1059,8 @@ def test_null_blob(self):
[b'first_blob', None, b'third_blob', None, b'fifth_blob'],
)
- def test_update_blob_column(self):
Review Comment:
> Just ignore this test is OK.
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Ban blob column updates in update-by-row-id [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #8227:
URL: https://github.com/apache/paimon/pull/8227#discussion_r3408075825
##########
paimon-python/pypaimon/tests/blob_table_test.py:
##########
@@ -1059,6 +1059,141 @@ def test_null_blob(self):
[b'first_blob', None, b'third_blob', None, b'fifth_blob'],
)
+ def test_update_blob_column_rejected(self):
Review Comment:
Do not add test to `rejected`. If this feature is something we want to add later, there's no need to test and reject it now. Instead of adding tests that reject it, it's better to fix it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Ban blob column updates in update-by-row-id [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #8227:
URL: https://github.com/apache/paimon/pull/8227#issuecomment-4699037403
> I think you can fix it directly. The master branch will definitely have a lot of developing features.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Ban blob column updates in update-by-row-id [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #8227:
URL: https://github.com/apache/paimon/pull/8227#discussion_r3407940927
##########
paimon-python/pypaimon/tests/blob_table_test.py:
##########
@@ -1059,10 +1059,8 @@ def test_null_blob(self):
[b'first_blob', None, b'third_blob', None, b'fifth_blob'],
)
- def test_update_blob_column(self):
Review Comment:
Just ignore this test is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Ban blob column updates in update-by-row-id [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #8227:
URL: https://github.com/apache/paimon/pull/8227#issuecomment-4698785235
Or you can research what 'not yet production ready' means? Where is the problem that we really can't modify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org